Skip to content

Adding additional support for b3multi propagator #31258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: integration
Choose a base branch
from
Open

Adding additional support for b3multi propagator #31258

wants to merge 2 commits into from

Conversation

tonyreigns
Copy link
Contributor

################################################################################################

@tonyreigns tonyreigns self-assigned this Apr 14, 2025
@tonyreigns
Copy link
Contributor Author

tonyreigns commented Apr 14, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 4 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@tonyreigns tonyreigns force-pushed the accessTelemetryTraceB3 branch from 449a0c3 to 1c08899 Compare April 14, 2025 18:39
@tonyreigns
Copy link
Contributor Author

tonyreigns commented Apr 14, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 4 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@tonyreigns
Copy link
Contributor Author

tonyreigns commented Apr 14, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@tonyreigns tonyreigns requested a review from pgunapal April 14, 2025 19:05
pgunapal
pgunapal requested changes Apr 14, 2025
View reviewed changes
...rnal_2_fat/fat/src/io/openliberty/microprofile/telemetry/logging/internal_fat/TestUtils.java Outdated
@@ -79,33 +86,36 @@ public static void runAccessApp(LibertyServer server, String type, String propag
String url = "http://" + server.getHostname() + ":" + server.getHttpDefaultPort() + "/MpTelemetryLogApp/AccessURL";
Log.info(c, "runApp", "---> Running the application with url : " + url);

String requestHeader = null;
String traceData = null;
ArrayList<String> requestHeaders = new ArrayList<String>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this, as its un-used.

...rnal_2_fat/fat/src/io/openliberty/microprofile/telemetry/logging/internal_fat/TestUtils.java Outdated
String requestHeader = null;
String traceData = null;
ArrayList<String> requestHeaders = new ArrayList<String>();
ArrayList<String> requestValues = new ArrayList<String>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this, as its un-used.

@tonyreigns tonyreigns force-pushed the accessTelemetryTraceB3 branch from f430bf5 to 8903008 Compare April 14, 2025 19:11
pgunapal
pgunapal approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@pgunapal pgunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 3 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 4 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgunapal pgunapal pgunapal approved these changes

Assignees

@tonyreigns tonyreigns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyreigns @LibbyBot @pgunapal