Test websphere integration with spring framework websocket #31260
+65
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
tjwatson
reviewed
Apr 14, 2025
| @@ -28,5 +28,8 @@ sourceCompatibility = 17 | |||
| apply from: '../wlp-gradle/subprojects/maven-central-mirror.gradle' | |||
|
|
|||
| dependencies { | |||
| implementation('org.springframework.boot:spring-boot-starter-websocket' + ':' + sv['springBoot']) | |||
| implementation('org.springframework.boot:spring-boot-starter-websocket') { | |||
| exclude module: 'spring-boot-starter-tomcat' //Temporarily excluding tomcat starter till it is removed in SpringBootThinUtil | |||
There was a problem hiding this comment.
Can you open an issue to fix the thinning for the recent versions of spring boot
There was a problem hiding this comment.
Opened #31262.
tjwatson
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #31125
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).