Skip to content

Create More WebSocket CheckPoint Tests #31264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: integration
Choose a base branch
from
Open

Create More WebSocket CheckPoint Tests #31264

wants to merge 2 commits into from
+1,030 −0

Conversation

volosied
Copy link
Member

@volosied volosied commented Apr 14, 2025 •
edited
Loading

for #31286

@volosied volosied self-assigned this Apr 14, 2025
@volosied volosied marked this pull request as draft April 14, 2025 19:45
@volosied volosied force-pushed the wsoc-checkpoint-fat branch 2 times, most recently from c0a9894 to 2e4605e Compare April 14, 2025 19:51
@volosied volosied force-pushed the wsoc-checkpoint-fat branch from 2e4605e to 1a893c5 Compare April 14, 2025 19:52
@volosied volosied changed the title Create io.openliberty.checkpoint_fat_wsoc FAT Create More WebSocket CheckPoint Tests Apr 14, 2025
@volosied volosied requested a review from tjwatson April 14, 2025 20:05
@volosied
Copy link
Member Author

volosied commented Apr 14, 2025 •
edited by LibbyBot
Loading

!build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 20 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

tjwatson
tjwatson requested changes Apr 15, 2025
View reviewed changes
Copy link
Member

@tjwatson tjwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor copyright comments and a small issue with calling setCheckpoint twice. Thanks for creating the new bucket. After this merges I will want us to move the websocket tests from /io.openliberty.checkpoint_fat/fat/src/io/openliberty/checkpoint/fat/WebSocketTest.java to this new bucket, but someone else can do that.

@volosied volosied force-pushed the wsoc-checkpoint-fat branch from 7c265a9 to ebe3b9a Compare April 16, 2025 13:14
@volosied volosied requested review from tjwatson and pnicolucci April 16, 2025 13:14
@volosied volosied force-pushed the wsoc-checkpoint-fat branch from ebe3b9a to 7227e4a Compare April 16, 2025 13:17
@volosied
Copy link
Member Author

volosied commented Apr 16, 2025 •
edited by LibbyBot
Loading

!build (view Open Liberty Personal Build - ⏳InProgress)

Note: Target locations of links might be accessible only to IBM employees.

@volosied volosied marked this pull request as ready for review April 16, 2025 13:17
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 20 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

tjwatson
tjwatson approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@tjwatson tjwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjwatson tjwatson tjwatson approved these changes

@pnicolucci pnicolucci Awaiting requested review from pnicolucci

Assignees

@volosied volosied

Labels
in:Web Components noproductcode team:Sirius
Projects
Web Tier Team
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@volosied @LibbyBot @tjwatson