Equinox package trace #33215
Equinox package trace #33215
Conversation
|
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
There was a problem hiding this comment.
Hello @tjwatson.
- There are few backdated copyrights that I did not mention because this is an overlay, and any dates can be updated if necessary when the overlay is removed.
- None of the concerns or changes I noted are mandatory.
- Finally, all changes I expected to find in this solution are here.
I'm not perfectly clear about the behavior of methods Debug.loaderWithClass(), Debug.loaderWithPackage(), and Debug.dynamicImport(), but their implementations are consistent with respect to how they return debug option strings.
|
|
||
| classload("org.osgi.framework.wiring.BundleWiring"); | ||
| List<String> found = server.findStringsInLogsAndTraceUsingMark("LoggerName:org.eclipse.osgi/debug/loader/packages"); | ||
| assertFalse("Expected to find debug/loader/packages LoggerName.", found.isEmpty()); |
There was a problem hiding this comment.
Never a fan of assertFalse(), but assertions here and on line 235 look correct.
| classload("org.osgi.framework.wiring.BundleWiring"); | ||
| List<String> found = server.findStringsInLogsAndTraceUsingMark("LoggerName:org.eclipse.osgi/debug/loader/packages"); | ||
| assertFalse("Expected to find debug/loader/packages LoggerName.", found.isEmpty()); | ||
| // need to escape parenthises for regex here. Expecting to not have trace for the org.osgi.framework package |
There was a problem hiding this comment.
Change spelling to parentheses here and on line 233.
| && !(EQUINOX_LOGGER_NAME.equals(level.getKey()) | ||
| || PERF_LOGGER_NAME.equals(level.getKey()))) { | ||
| int listIdx = level.getKey().lastIndexOf(ADD_LIST_KEY); | ||
| if (listIdx != -1) { |
There was a problem hiding this comment.
I've always thought idx >= 0 to be safer.
3 participants
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).