Netty needs to check for the xgzip encoding #33216
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#build (view Open Liberty Personal Build - Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
This causes the x-gzip tests to fail. |
volosied
approved these changes
Oct 24, 2025
pnicolucci
reviewed
Oct 24, 2025
|
|
||
| private boolean isCompressed(String encoding) { | ||
| return "gzip".equalsIgnoreCase(encoding) || "deflate".equalsIgnoreCase(encoding); | ||
| return "gzip".equalsIgnoreCase(encoding) || "deflate".equalsIgnoreCase(encoding) || "x-gzip".equalsIgnoreCase(encoding); |
There was a problem hiding this comment.
Where is this check done in Legacy? Just making sure we're not missing anything else.
There was a problem hiding this comment.
Also can we use HttpConstants here which looks to have values for all of these?
There was a problem hiding this comment.
To add to Paul's comment, perhaps create an array/hashmap of supported compression algorithms. Loop/look up for a match?
There was a problem hiding this comment.
We could turn it into an enum lookup, but this constants class already has them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netty didn't check for the x-gzip encoding for the incoming request.