Skip to content

Conversation

@jhanders34
Copy link
Member

  • When 2 or more test projects end up having test bundles with the same name, there can be errors during the build when both projects try to release the same bundle name and it already was released. There is no need to actually release test bundles to the bnd repository. This PR updates to not release the bundles whose names are shared across multiple test projects.

  • In the future it would be good to update all test bundle bnd files to not release, but this is a stop gap in order to prevent people from getting build errors when doing gradle with parallel enabled.

  • Also updated bnd.bnd files to remove SymbolicName settings when the projects has sub bundles and set the symbolic name in the sub bundles.

  • I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).

  • If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).

  • If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

@jhanders34
Copy link
Member Author

jhanders34 commented Oct 24, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link
Member

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 26 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 5 unit test files were changed.

  • Check that the build did not break the affected unit test suite(s).

  • 10 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

fritze2
fritze2 previously approved these changes Oct 24, 2025
Copy link
Member

@fritze2 fritze2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was Bundle-Name, Bundle-SymbolicName, and Bundle-Description removed in some cases? I see now, when it has -sub bundles.

How do you know whether a bundle is a test bundle to know that releaserepo: needed to be added to disable it from being released? It is a simple change, so assuming it passes the build it looks good. I just wonder if there are test bundles missed and how you know you got them all.

@jhanders34
Copy link
Member Author

How do you know whether a bundle is a test bundle to know that releaserepo: needed to be added to disable it from being released? It is a simple change, so assuming it passes the build it looks good. I just wonder if there are test bundles missed and how you know you got them all.

I looked at all symbolic names and if it was duplicated I changed not to release the bundle. They are test bundles if in test projects. The non test ones I just removed the bnd.bnd one if it was already on original.bnd.

@jhanders34
Copy link
Member Author

jhanders34 commented Oct 25, 2025

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link
Member

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 26 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 5 unit test files were changed.

  • Check that the build did not break the affected unit test suite(s).

  • 9 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants