SpringBoot test application cleanup #33221
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch from using `apply plugin` to putting the plugins into `plugins` - Remove `bootJar` config from build.gradle files where a war is built - Remove `jar` being disabled in build.gradle and put it into spring.gradle like what is done to disable `war`. - Switch to using version 1.1.7 of the dependency-management plugin - Clean up sv usage where it was commented out - Update to not specify `java` plugin if the `war` plugin is specified
|
!build (view Open Liberty Personal Build - Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from using
apply pluginto putting the plugins intopluginsRemove
bootJarconfig from build.gradle files where a war is builtRemove
jarbeing disabled in build.gradle and put it into spring.gradle like what is done to disablewar.Switch to using version 1.1.7 of the dependency-management plugin
Clean up sv usage where it was commented out
Update to not specify
javaplugin if thewarplugin is specifiedI have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".