Give head start to listener quiesce #33720
Open
+53
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblye
changed the title
jimblye
force-pushed
the
Give-head-start-for-listener-quiesce
branch
from
2d0463f to
047dc1e
Compare
Member
Author
|
#build (view Open Liberty Personal Build - Note: Target locations of links might be accessible only to IBM employees. |
Member
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).################################################################################################
Currently the RuntimeUpdateManager kicks off the quiesce for Listeners and then immediately begins quiescing threads. So it all happens in parallel. This race condition potentially allows new work to come in while the threads are quiescing. This proposed change causes the RuntimeUpdateManager to wait up to 2 seconds before quiescing the threads. It's not a perfect solution, but it gives the listeners a better chance of winning the race without adding to the total quiesceTimeout time.