Update MXBean to API project#35253
Open
devalibm wants to merge 2 commits into
Open
Conversation
TheoGkoumas
previously approved these changes
Jul 8, 2026
Member
There was a problem hiding this comment.
Confirmed that all fields are aligned with the ones on source classes McpSessionStatistics and McpOperationStatistics.
If I have to be picky, I would rename "Stats" to "Statistics" on McpOperationStatsMXBean in order to be consistent on naming between those two MXBeans.
Other than that, it looks good to merge! Good job.
TheoGkoumas
approved these changes
Jul 9, 2026
TheoGkoumas
left a comment
TheoGkoumas
left a comment
Member
There was a problem hiding this comment.
Looks good!
Please ensure that you have successfully executed the FATSuite in FULL mode before merging.
Azquelt
requested changes
Jul 9, 2026
Azquelt
left a comment
Azquelt
left a comment
Member
There was a problem hiding this comment.
- package should be moved, not copied to the API project
- package should be added to
IBM-API-Packagein the feature file - add a test that the MXBean can be accessed, using the interface, from an application
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).