Skip to content

UI bugs found in footer part of docs #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
navaneethsnair1 wants to merge 5 commits into from
Closed

UI bugs found in footer part of docs #3934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af00e2e
address issues associated with guides in singlepane
navaneethsnair1 Sep 18, 2024
307f252
build: update to Open Liberty 24.0.0.12
kinueng Jan 2, 2025
f83e3c5
solving UI bug in footer of docs part
navaneethsnair1 Jan 24, 2025
bf2cf1e
UI bug in footer of docs part#2
navaneethsnair1 Jan 24, 2025
b440958
cleaning up outdated code
navaneethsnair1 Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile.demo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.draft
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.prod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ COPY --from=docs --chown=1001:0 /temp-docs/docs /target/openliberty-website-1.0-
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.staging
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ COPY --from=docs --chown=1001:0 /temp-docs/docs /target/openliberty-website-1.0-
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/blogs/Dockerfile.blogs.draft
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/blogs/Dockerfile.blogs.staging
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/certifications/Dockerfile.certifications.draft
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/certifications/Dockerfile.certifications.staging
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/docs/Dockerfile.docs.draft
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/docs/Dockerfile.docs.staging
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/guides/Dockerfile.guides.draft
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/guides/Dockerfile.guides.staging
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
2 changes: 1 addition & 1 deletion docker/ui-only/Dockerfile.ui-only
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ RUN ./mvnw -B -Dhttps.protocols=TLSv1.2 compile war:exploded
#
#
#
FROM icr.io/appcafe/open-liberty:24.0.0.11-kernel-slim-java8-openj9-ubi as runtime
FROM icr.io/appcafe/open-liberty:24.0.0.12-kernel-slim-java8-openj9-ubi as runtime
ENV SEC_TLS_TRUSTDEFAULTCERTS true

COPY --chown=1001:0 src/main/wlp/server.xml /config/server.xml
Expand Down
16 changes: 16 additions & 0 deletions src/main/content/_assets/css/guide-common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,13 +512,29 @@
#guide_content .code_command > .code_block_wrapper:before {
display: none;
}

.view_code{
display: block;
}

.code_command pre{
cursor:text;
}
}

@media (min-width: 1170px) {
#background_container {
background-image: inherit;
margin-bottom: 0;
}

.view_code{
display: none;
}

.code_command pre{
cursor:pointer;
}
}

@media (min-width: 1440px) {
Expand Down
9 changes: 9 additions & 0 deletions src/main/content/_assets/css/guide-multipane.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,15 @@ body {
}
}

@media (max-width: 1169.98px){
.copyFileButton{
right: 40px;
&:hover {
right: 39px;
}
}
}

.CodeRay .line-numbers {
display: inline-block;
visibility: hidden;
Expand Down
7 changes: 0 additions & 7 deletions src/main/content/_assets/css/openliberty.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,8 +559,6 @@ footer {
#footer_support_link, #footer_blog_link, #footer_docs_link, #footer_guides_link {
margin-left: 28px;
}


}

@media (max-width: 991.98px) {
Expand All @@ -577,11 +575,6 @@ footer {
font-size: 14px;
float: right;
}

#footer_support_link, #footer_blog_link {
margin-left: 28px;
}

}

@media (max-width: 910px) {
Expand Down
1 change: 1 addition & 0 deletions src/main/content/_assets/js/guide-common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ $(document).ready(function () {
});

$(window).on("resize", function () {
(inSingleColumnView()) ? $(".code_command").removeClass("hotspot") : $(".code_command").addClass("hotspot");
if (!inSingleColumnView()){
$("#code_column").css("top", "0px");
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/content/antora_ui/src/partials/footer-content.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<a id="footer_get_started_link" href="/start" aria-label="Open Liberty Get Started" class="right_footer_link blue_link_light_background">Get Started</a>
<a id="footer_guides_link" href="/guides" aria-label="Open Liberty Guides" class="right_footer_link blue_link_light_background">Guides</a>
<a id="footer_docs_link" href="/docs" aria-label="Open Liberty Docs" class="right_footer_link blue_link_light_background">Docs</a>
<a id="footers_support_link" href="/support" aria-label="Open Liberty Support" class="right_footer_link blue_link_light_background">Support</a>
<a id="footer_support_link" href="/support" aria-label="Open Liberty Support" class="right_footer_link blue_link_light_background">Support</a>
<a id="footer_blog_link" href="/blog" aria-label="Open Liberty Blog" class="right_footer_link blue_link_light_background">Blog</a>
</div>
</div>
Expand Down
9 changes: 1 addition & 8 deletions src/main/content/antora_ui/src/sass/openliberty.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,11 +521,9 @@ footer {
float: left;
}

#footer_support_link, #footer_blog_link {
#footer_support_link, #footer_blog_link, #footer_docs_link, #footer_guides_link {
margin-left: 28px;
}


}

@media (max-width: 991.98px) {
Expand All @@ -542,11 +540,6 @@ footer {
font-size: 14px;
float: right;
}

#footer_support_link, #footer_blog_link {
margin-left: 28px;
}

}

@media (max-width: 767.98px) {
Expand Down
Loading