-
Notifications
You must be signed in to change notification settings - Fork 42
Updating dockerfile for blogs and adding one for guides #3988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # Created by [email protected], Twitter/GitHub/Docker username: @lauracowen | ||
| # 2017-11-02 | ||
| # Updated Oct. 2018 by Kin Ueng | ||
| # Updated May 2024 by Mark Swatosh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure, did you mean May 2025?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That date is unfortunately correct, this has been sitting in my workspace for awhile
|
Also, can you please raise a PR to draft first. Please see this instructions given in wiki on how to contribute. Do reach out for any clarifications. Thank you! |
Please check this also @mswatosh |
|
Hey @navaneethsnair1 , I skipped draft since there won't be anything visually to check. Since these are just dev tool changes nothing in this PR should be picked up by the website build. Staging should be enough to confirm that |
Hi @mswatosh , I understand that. |
|
@navaneethsnair1 Thanks for creating the draft PR, I took a quick look at the draft site and don't see any issues, is this good to merge into staging now? |
Hi @mswatosh , I ve copied all the changes and pushed them to draft and now to staging. This will be moved to prod on the next iteration. |
What was changed and why?
This adds a dockerfile to simplify guides testing and updates the one for blogs testing. The changes are only for development environments and should have no impact on the website.
gem_dependencies.shis only used by these dockerfiles, not in the building of the website itself.Tested using browser:
Did you test accessibility: