Skip to content

Conversation

@mswatosh
Copy link
Member

@mswatosh mswatosh commented Jun 6, 2025

What was changed and why?

This adds a dockerfile to simplify guides testing and updates the one for blogs testing. The changes are only for development environments and should have no impact on the website.

gem_dependencies.sh is only used by these dockerfiles, not in the building of the website itself.

Tested using browser:

  • Firefox (Desktop)
  • Safari (Desktop)
  • Chrome (Desktop)

Did you test accessibility:

  • IBM Equal Access Accessibilty Checker
  • Jaws (only relevant for new UX flows)

# Created by [email protected], Twitter/GitHub/Docker username: @lauracowen
# 2017-11-02
# Updated Oct. 2018 by Kin Ueng
# Updated May 2024 by Mark Swatosh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, did you mean May 2025?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That date is unfortunately correct, this has been sitting in my workspace for awhile

@navaneethsnair1
Copy link
Contributor

Also, can you please raise a PR to draft first. Please see this instructions given in wiki on how to contribute.

Do reach out for any clarifications. Thank you!

@navaneethsnair1
Copy link
Contributor

Also, can you please raise a PR to draft first. Please see this instructions given in wiki on how to contribute.

Do reach out for any clarifications. Thank you!

Please check this also @mswatosh

@mswatosh
Copy link
Member Author

mswatosh commented Jun 9, 2025

Hey @navaneethsnair1 , I skipped draft since there won't be anything visually to check. Since these are just dev tool changes nothing in this PR should be picked up by the website build. Staging should be enough to confirm that

@navaneethsnair1
Copy link
Contributor

Hey @navaneethsnair1 , I skipped draft since there won't be anything visually to check. Since these are just dev tool changes nothing in this PR should be picked up by the website build. Staging should be enough to confirm that

Hi @mswatosh , I understand that.
But we need to maintain draft, staging and prod on same level. So it is recommended to add changes on draft before to staging. Also please see the instructions to clone the repo and raising PR

@mswatosh
Copy link
Member Author

@navaneethsnair1 Thanks for creating the draft PR, I took a quick look at the draft site and don't see any issues, is this good to merge into staging now?

@navaneethsnair1
Copy link
Contributor

@navaneethsnair1 Thanks for creating the draft PR, I took a quick look at the draft site and don't see any issues, is this good to merge into staging now?

Hi @mswatosh , I ve copied all the changes and pushed them to draft and now to staging. This will be moved to prod on the next iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants