Skip to content

Conversation

@uhryniuk
Copy link

Includes all kubernetes files and build scripts to for all the images used.

Was able to get kubernetes work with local images as well.

@jacobwdv
Copy link
Member

jacobwdv commented Mar 3, 2023

@kabicin should we be merging this or do your changes work outside of these?

@kabicin
Copy link
Member

kabicin commented Mar 3, 2023

Yes we can merge these changes bundled as part of v3 once I get another review on my additional commits.

jacobwdv and others added 6 commits March 15, 2023 08:52
…104)

* adding unlimited log size for space rover logs and leaderboard logs

* modifying bootstrap.properties to use 500mb max and 50 log files before rolling over

* adding bootstrap.properties to dockerfiles
Change wording for Leaderboard service with regards to the Jakarta EE 9.1 REST usage info:

Propose changing:
Used REST endpoints for interfacing with the leaderboard. 
to
Used for REST endpoints to interface with the leaderboard service.
Copy link
Member

@pgunapal pgunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabicin I see you changed the ports for all the services in the Docker-compose files, would this break the current V3 game? Can players still clone the repo and play the game as-is (w/ containers) with the V3 devices? I think we should make the back-ward compatibility easier, since there are replicas in the different geos, that may still want to use the old container offline behaviour.

@kabicin
Copy link
Member

kabicin commented Mar 21, 2023

@pgunapal good point, the networking is a bit different in docker vs kubernetes. I adjusted the port for leaderboard to work correctly with docker-compose scripts and added mpConfig environment variables so a rebuild won't be required.

@kabicin kabicin requested a review from pgunapal March 21, 2023 18:32
Copy link
Member

@pgunapal pgunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwdv
Copy link
Member

@pgunapal did you want to merge this into main? Should we branch off our local stable main branch first so we have it to fall back to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants