-
Notifications
You must be signed in to change notification settings - Fork 7
Issue 100 #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@kabicin should we be merging this or do your changes work outside of these? |
|
Yes we can merge these changes bundled as part of v3 once I get another review on my additional commits. |
…104) * adding unlimited log size for space rover logs and leaderboard logs * modifying bootstrap.properties to use 500mb max and 50 log files before rolling over * adding bootstrap.properties to dockerfiles
…#117) Fixing stats and bugs found on town hall day
Change wording for Leaderboard service with regards to the Jakarta EE 9.1 REST usage info: Propose changing: Used REST endpoints for interfacing with the leaderboard. to Used for REST endpoints to interface with the leaderboard service.
Creating startup script for space rover localhost execution
integrated latency reducing changes as well as fixing bugs when starting containers / gestures using the script.
Updating to latest code
sending stop message if hand leaves the frame
adding battery voltage metric updating Mock Rover
…p diagnose issues with disconnecting sockets (#128)
…g var using ConfigMap
pgunapal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kabicin I see you changed the ports for all the services in the Docker-compose files, would this break the current V3 game? Can players still clone the repo and play the game as-is (w/ containers) with the V3 devices? I think we should make the back-ward compatibility easier, since there are replicas in the different geos, that may still want to use the old container offline behaviour.
|
@pgunapal good point, the networking is a bit different in docker vs kubernetes. I adjusted the port for leaderboard to work correctly with docker-compose scripts and added mpConfig environment variables so a rebuild won't be required. |
pgunapal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@pgunapal did you want to merge this into main? Should we branch off our local stable main branch first so we have it to fall back to? |
Includes all kubernetes files and build scripts to for all the images used.
Was able to get kubernetes work with local images as well.