Skip to content

Prismatic export plugin #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Zaraka
Copy link
Contributor

@Zaraka Zaraka commented Sep 4, 2024

Currently very basic in its features, it only merges a few recognized channels and derives several parameter types.
The version of Prismatic that supports these fixture files will be made available this week.

@Zaraka Zaraka marked this pull request as draft September 4, 2024 12:07
@Zaraka Zaraka changed the title Prismatic plugin Prismatic export plugin Sep 4, 2024
@Zaraka Zaraka marked this pull request as ready for review September 4, 2024 12:56
Currently very basic in its features, only merges few recognized channels and derives several of parameter types
@FloEdelmann FloEdelmann added the new-plugin Request or implementation to add a new plugin. label Sep 11, 2024
@FloEdelmann
Copy link
Member

FloEdelmann commented Sep 11, 2024

Wow, really cool! 🙂
However, it's quite a bit to review and I don't know how fast I'll get to it. In the meantime, could you have a look at the "cognitive complexity" ESLint warnings (sonarjs/cognitive-complexity)? Splitting those functions would make them much more readable and thus easier to review and maintain.

@Zaraka
Copy link
Contributor Author

Zaraka commented Oct 17, 2024

@FloEdelmann I have fixed the ESLint warnings a squashed some bugs.

Prismatic version which supports this .prd output file is now released and available for download at prismatic.art, hit me up so I can send you a license to try it out if you are interested

Many features are still not supported, for example, the matrixes, and capabilities are almost ignored.
I will get around and keep this plugin updated as I decided ofl will be the primary way to supply Fixture specs into Prismatic, so this is definitely not my final PR on this matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-plugin Request or implementation to add a new plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants