Skip to content

Auto-Programs colors and #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: branch2024-11-23T11-11-48
Choose a base branch
from
Open

Auto-Programs colors and #4452

wants to merge 1 commit into from

Conversation

terokorp
Copy link
Contributor

@terokorp terokorp commented Dec 1, 2024

  • ColorPreset type instead of Generic type
  • EffectSpeed instead of Speed

@terokorp terokorp force-pushed the branch2024-11-23T11-11-48 branch 3 times, most recently from bc13b05 to e5b55cb Compare December 1, 2024 07:47
@terokorp
Auto-Programs colors
c556546 
* ColorPreset instead of Generic type
* EffectSpeed instead of Speed
@terokorp terokorp force-pushed the branch2024-11-23T11-11-48 branch from e5b55cb to c556546 Compare December 1, 2024 07:50
FloEdelmann
FloEdelmann requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto programs should have the Effect capability type rather than ColorPreset. ColorPreset is only meant for static colors.

@FloEdelmann FloEdelmann added the component-fixture Affects one or more existing fixture definitions. label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann requested changes

Assignees
No one assigned
Labels
component-fixture Affects one or more existing fixture definitions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terokorp @FloEdelmann