Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture purelight/3-way-mini #4588

Closed
wants to merge 2 commits into from
Closed

Conversation

FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture purelight/3-way-mini

Fixture warnings / errors

  • purelight/3-way-mini
    • ❌ File does not match schema: fixture/availableChannels/Makro Speed/capability/speedStart "slow" must match pattern "^-?[0-9]+(.[0-9]+)?Hz$"
    • ❌ File does not match schema: fixture/availableChannels/Makro Speed/capability/speedStart "slow" must match pattern "^-?[0-9]+(.[0-9]+)?rpm$"
    • ❌ File does not match schema: fixture/availableChannels/Makro Speed/capability/speedStart "slow" must match pattern "^-?[0-9]+(.[0-9]+)?%$"
    • ❌ File does not match schema: fixture/availableChannels/Makro Speed/capability/speedStart "slow" must be equal to one of [fast CW, slow CW, stop, slow CCW, fast CCW]
    • ❌ File does not match schema: fixture/availableChannels/Makro Speed/capability/speedStart "slow" must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Makro Speed/capability/speedEnd "fast" must match pattern "^-?[0-9]+(.[0-9]+)?Hz$"
    • ❌ File does not match schema: fixture/availableChannels/Makro Speed/capability/speedEnd "fast" must match pattern "^-?[0-9]+(.[0-9]+)?rpm$"
    • ❌ File does not match schema: fixture/availableChannels/Makro Speed/capability/speedEnd "fast" must match pattern "^-?[0-9]+(.[0-9]+)?%$"
    • ❌ File does not match schema: fixture/availableChannels/Makro Speed/capability/speedEnd "fast" must be equal to one of [fast CW, slow CW, stop, slow CCW, fast CCW]
    • ❌ File does not match schema: fixture/availableChannels/Makro Speed/capability/speedEnd "fast" must match exactly one schema in oneOf
    • ⚠️ Please check if manufacturer is correct and add manufacturer URL.
    • ⚠️ Please check 16bit channel 'Makros': The corresponding coarse channel could not be detected.

User comment

This Fixture has 15 Channel, Because the devices on the market are different

Thank you @DerHoffmann!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Jan 24, 2025
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

purelight / 3-way-mini: d-light / attributes-correctness
  • ✔️ purelight/3-way-mini-11-Kanal Modus.xml
  • ✔️ purelight/3-way-mini-14-Kanal Modus.xml
  • ❌ purelight/3-way-mini-15-Kanal Modus.xmlError parsing XML: Duplicate parameter name: FOCUS/PAN
✔️ purelight / 3-way-mini: dmxcontrol3 / channel-numbers
  • ✔️ purelight-3-way-mini-11-Kanal-Modus.xml
  • ✔️ purelight-3-way-mini-14-Kanal-Modus.xml
  • ✔️ purelight-3-way-mini-15-Kanal-Modus.xml
purelight / 3-way-mini: dragonframe / json-schema-conformity
  • ❌ purelight/3-way-mini.jsonfixture/availableChannels/Makro Speed/capability/speedStart "slow" must match pattern "^-?[0-9]+(\.[0-9]+)?Hz$"
    fixture/availableChannels/Makro Speed/capability/speedStart "slow" must match pattern "^-?[0-9]+(\.[0-9]+)?rpm$"
    fixture/availableChannels/Makro Speed/capability/speedStart "slow" must match pattern "^-?[0-9]+(\.[0-9]+)?%$"
    fixture/availableChannels/Makro Speed/capability/speedStart "slow" must be equal to one of [fast CW, slow CW, stop, slow CCW, fast CCW]
    fixture/availableChannels/Makro Speed/capability/speedStart "slow" must match exactly one schema in oneOf
    fixture/availableChannels/Makro Speed/capability (type: PanContinuous) must match "then" schema
  • ✔️ manufacturers.json
purelight / 3-way-mini: millumin / json-schema-conformity
  • ❌ purelight/3-way-mini.jsonfixture/availableChannels/Reset (type: Nothing) must NOT have more than 1 properties
    fixture/availableChannels/Reset (type: Nothing) must have required property 'name'
    fixture/availableChannels/Reset (type: Nothing) must match exactly one schema in oneOf
✔️ purelight / 3-way-mini: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Purelight-3-Way-mini.qxf
✔️ purelight / 3-way-mini: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Purelight-3-Way-mini.qxf

@kengruven
Copy link
Contributor

kengruven commented Jan 25, 2025

Looks like an old version of #4589 (exactly one word changed).

@FloEdelmann FloEdelmann added the duplicate Same feature request, bug report or implementation as another issue/PR. label Jan 26, 2025
@FloEdelmann FloEdelmann deleted the branch2025-01-24T15-23-49 branch January 26, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Same feature request, bug report or implementation as another issue/PR. new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants