Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture shehds/led-spot-100w #4612

Closed
wants to merge 1 commit into from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture shehds/led-spot-100w

Fixture warnings / errors

  • shehds/led-spot-100w
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/0/brightnessStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/0/brightnessStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/0/brightnessStart 0 must be equal to one of [off, dark, bright]
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/0/brightnessStart 0 must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/0/brightnessEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/0/brightnessEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/0/brightnessEnd 1 must be equal to one of [off, dark, bright]
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/0/brightnessEnd 1 must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/1/brightnessStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/1/brightnessStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/1/brightnessStart 0 must be equal to one of [off, dark, bright]
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/1/brightnessStart 0 must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/1/brightnessEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/1/brightnessEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/1/brightnessEnd 1 must be equal to one of [off, dark, bright]
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/1/brightnessEnd 1 must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/2/brightnessStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/2/brightnessStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/2/brightnessStart 0 must be equal to one of [off, dark, bright]
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/2/brightnessStart 0 must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/2/brightnessEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/2/brightnessEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/2/brightnessEnd 1 must be equal to one of [off, dark, bright]
    • ❌ File does not match schema: fixture/availableChannels/Dim/capabilities/2/brightnessEnd 1 must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Sh1/capabilities/0/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/Sh1/capabilities/1 (type: ShutterStrobe) must have required property 'shutterEffect'
    • ❌ File does not match schema: fixture/availableChannels/Pos MSpeed/capability/speedStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Pos MSpeed/capability/speedStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Pos MSpeed/capability/speedStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Pos MSpeed/capability/speedStart 0 must be equal to one of [fast, slow, stop, slow reverse, fast reverse]
    • ❌ File does not match schema: fixture/availableChannels/Pos MSpeed/capability/speedStart 0 must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Pos MSpeed/capability/speedEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Pos MSpeed/capability/speedEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Pos MSpeed/capability/speedEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Pos MSpeed/capability/speedEnd 1 must be equal to one of [fast, slow, stop, slow reverse, fast reverse]
    • ❌ File does not match schema: fixture/availableChannels/Pos MSpeed/capability/speedEnd 1 must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/G1/capabilities/7/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G1/capabilities/8/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G1/capabilities/9/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G1/capabilities/10/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G1/capabilities/11/slotNumber NaN must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G1/capabilities must NOT have duplicate items (items ## 9 and 10 are identical)
    • ❌ File does not match schema: fixture/availableChannels/G2/capabilities/6/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G2/capabilities/7/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G2/capabilities/8/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G2/capabilities/9/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G2/capabilities/10/slotNumber NaN must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G2/capabilities must NOT have duplicate items (items ## 8 and 9 are identical)
    • ❌ File does not match schema: fixture/availableChannels/G2 <>/capabilities/0/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G2 <>/capabilities/1/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G2 <>/capabilities/2/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/G2 <>/capabilities must NOT have duplicate items (items ## 1 and 2 are identical)
    • ❌ File does not match schema: fixture/availableChannels/Prism1/capabilities/1/dmxRange/1 -1 must be >= 0
    • ❌ File does not match schema: fixture/availableChannels/Focus1/capability/distanceStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Focus1/capability/distanceStart 0 must be string
    • ❌ File does not match schema: fixture/availableChannels/Focus1/capability/distanceStart 0 must be equal to one of [near, far]
    • ❌ File does not match schema: fixture/availableChannels/Focus1/capability/distanceStart 0 must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Focus1/capability/distanceEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Focus1/capability/distanceEnd 1 must be string
    • ❌ File does not match schema: fixture/availableChannels/Focus1/capability/distanceEnd 1 must be equal to one of [near, far]
    • ❌ File does not match schema: fixture/availableChannels/Focus1/capability/distanceEnd 1 must match exactly one schema in oneOf
    • ⚠️ Please add fixture categories.
    • ⚠️ Please add relevant links to the fixture.
    • ⚠️ Please add physical data to the fixture.

Thank you Mads Vejrup!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

shehds / led-spot-100w: d-light / attributes-correctness
  • Unable to export fixture: Exporting fixture mode shehds/led-spot-100w/Default failed: Error: 'null' is not a valid entity string.
shehds / led-spot-100w: dmxcontrol3 / channel-numbers
  • Unable to export fixture: Exporting fixture mode shehds/led-spot-100w/Default failed: TypeError: Cannot read properties of null (reading 'toLowerCase')
shehds / led-spot-100w: dragonframe / json-schema-conformity
  • ❌ shehds/led-spot-100w.jsonfixture/availableChannels/Dim/capabilities/0/brightnessStart 0 must be string
    fixture/availableChannels/Dim/capabilities/0/brightnessStart 0 must be string
    fixture/availableChannels/Dim/capabilities/0/brightnessStart 0 must be equal to one of [off, dark, bright]
    fixture/availableChannels/Dim/capabilities/0/brightnessStart 0 must match exactly one schema in oneOf
    fixture/availableChannels/Dim/capabilities/0 (type: Intensity) must match "then" schema
  • ✔️ manufacturers.json
shehds / led-spot-100w: millumin / json-schema-conformity
  • Unable to export fixture: Exporting fixture shehds/led-spot-100w failed: Error: 'null' is not a valid entity string.
shehds / led-spot-100w: qlcplus_4.12.2 / fixture-tool-validation
  • Unable to export fixture: Exporting fixture shehds/led-spot-100w failed: Error: 'null' is not a valid entity string.
shehds / led-spot-100w: qlcplus_4.12.2 / xsd-schema-conformity
  • Unable to export fixture: Exporting fixture shehds/led-spot-100w failed: Error: 'null' is not a valid entity string.

@kengruven
Copy link
Contributor

Looks like the same fixture as #4353, which has already been reviewed.

Like all automatic GDTF conversions, this one is pretty bad. A lot of the functions and DMX ranges make no sense at all.

Recommend closing this one.

@FloEdelmann FloEdelmann added incomplete Only partly implemented, needs considerate amount of work to finish/improve. duplicate Same feature request, bug report or implementation as another issue/PR. and removed incomplete Only partly implemented, needs considerate amount of work to finish/improve. labels Feb 6, 2025
@FloEdelmann FloEdelmann closed this Feb 6, 2025
@FloEdelmann FloEdelmann deleted the branch2025-02-04T15-23-33 branch February 6, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Same feature request, bug report or implementation as another issue/PR. new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants