Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture psl/master-7x40-wash #4680

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture psl/master-7x40-wash

Fixture warnings / errors

  • psl/master-7x40-wash
    • ❌ Channel key 'Positionmspeed' is already defined (maybe in another letter case).
    • ⚠️ Mode '17 ch' should have shortName '17ch' instead of '17 ch'.
    • ⚠️ Mode '17 ch' should have shortName '17ch' instead of '17 ch'.
    • ⚠️ Unused channel(s): pan, pan/tilt speed, tilt, tiltfine, pan 2, pan 2 fine, colorrgb1
    • ⚠️ Category 'Color Changer' suggested since there are ColorPreset or ColorIntensity capabilities or Color wheel slots.

Thank you SeanGlobage!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Feb 28, 2025
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ psl / master-7x40-wash: d-light / attributes-correctness
  • ✔️ psl/master-7x40-wash-17 ch.xml
✔️ psl / master-7x40-wash: dmxcontrol3 / channel-numbers
  • ✔️ psl-master-7x40-wash-17-ch.xml
✔️ psl / master-7x40-wash: dragonframe / json-schema-conformity
  • ✔️ psl/master-7x40-wash.json
  • ✔️ manufacturers.json
✔️ psl / master-7x40-wash: millumin / json-schema-conformity
  • ✔️ psl/master-7x40-wash.json
psl / master-7x40-wash: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/PSL-MASTER-7X40-WASH.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected ./manufacturer/fixture.qxf: Invalid ZOOM degrees 1 definitions processed. 2 errors detected
psl / master-7x40-wash: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/PSL-MASTER-7X40-WASH.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant