Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture subtitles-cloud/subtitlescloudconnector #4683

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture subtitles-cloud/subtitlescloudconnector

Thank you @jvk75!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Mar 2, 2025
Copy link

github-actions bot commented Mar 2, 2025

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ subtitles-cloud / subtitlescloudconnector: d-light / attributes-correctness
  • ✔️ subtitles-cloud/subtitlescloudconnector-Control Show.xml
✔️ subtitles-cloud / subtitlescloudconnector: dmxcontrol3 / channel-numbers
  • ✔️ subtitles-cloud-subtitlescloudconnector-Control-Show.xml
subtitles-cloud / subtitlescloudconnector: dragonframe / json-schema-conformity
  • ❌ subtitles-cloud/subtitlescloudconnector.jsonfixture/physical/DMXconnector "RJ45" must be equal to one of [3-pin, 3-pin (swapped +/-), 3-pin XLR IP65, 5-pin, 5-pin XLR IP65, 3-pin and 5-pin, 3.5mm stereo jack]
  • ✔️ manufacturers.json
subtitles-cloud / subtitlescloudconnector: millumin / json-schema-conformity
  • ❌ subtitles-cloud/subtitlescloudconnector.jsonfixture/physical/DMXconnector "RJ45" must be equal to one of [3-pin, 5-pin, 3-pin (swapped +/-), 3-pin and 5-pin, 3-pin XLR IP65, 3.5mm stereo jack]
subtitles-cloud / subtitlescloudconnector: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Subtitles-Cloud-SubtitlesCloudConnector.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected ./manufacturer/fixture.qxf: Invalid power consumption 1 definitions processed. 2 errors detected
subtitles-cloud / subtitlescloudconnector: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Subtitles-Cloud-SubtitlesCloudConnector.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

@jvk75
Copy link

jvk75 commented Mar 4, 2025

@FloEdelmann what still needs to be done to get this new fixture merged?

@kengruven
Copy link
Contributor

This is an interesting and unique "fixture". This all looks reasonable, though I can't find any documentation to confirm.

The one change I might make is possibly changing some/all "Generic" to "Maintenance" -- do these triggers require any delay? But I wouldn't hold it back for such a trivial change.

@jvk75
Copy link

jvk75 commented Mar 13, 2025

@kengruven the documentation is in the works. Subtitles Cloud is a accessibility service. We have built a support for triggering e.g. the subtitles with DMX (via ArtNet and sACN).
The "fixture" here is defining the operations that our service understands from DMX point.
I'm happy to do needed changes to the definition if needed, as well as answer more questions that might arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants