Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture stairville/led-bossfx-2-pro #4719

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture stairville/led-bossfx-2-pro

Thank you Gilles!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Mar 21, 2025
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ stairville / led-bossfx-2-pro: d-light / attributes-correctness
  • ✔️ stairville/led-bossfx-2-pro-4ch.xml
stairville / led-bossfx-2-pro: dmxcontrol3 / channel-numbers
  • ❌ stairville-led-bossfx-2-pro-4ch.xmlTypeError: Cannot read properties of undefined (reading 'filter')
✔️ stairville / led-bossfx-2-pro: dragonframe / json-schema-conformity
  • ✔️ stairville/led-bossfx-2-pro.json
  • ✔️ manufacturers.json
✔️ stairville / led-bossfx-2-pro: millumin / json-schema-conformity
  • ✔️ stairville/led-bossfx-2-pro.json
✔️ stairville / led-bossfx-2-pro: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Stairville-LED-BossFX-2-Pro.qxf
✔️ stairville / led-bossfx-2-pro: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Stairville-LED-BossFX-2-Pro.qxf

Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual has 4/5/7/25-ch modes. This OFL mapping only has 4 NoFunction channels in a single mode. As it stands now, that's not useful for driving this fixture.

"https://fast-images.static-thomann.de/pics/atg/atgdata/document/manual/c_466569_v5_en_online.pdf"
],
"productPage": [
"https://www.thomann.co.uk/stairville_led_bossfx_2_pro_bundle.htm?__cTr=65fb4896-7dfb-4aa2-8983-9543c9e19534&shp=eyJjb3VudHJ5IjoiZ2IiLCJjdXJyZW5jeSI6NCwibGFuZ3VhZ2UiOjJ9&reload=1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"https://www.thomann.co.uk/stairville_led_bossfx_2_pro_bundle.htm?__cTr=65fb4896-7dfb-4aa2-8983-9543c9e19534&shp=eyJjb3VudHJ5IjoiZ2IiLCJjdXJyZW5jeSI6NCwibGFuZ3VhZ2UiOjJ9&reload=1"
"https://www.thomann.co.uk/stairville_led_bossfx_2_pro_bundle.htm"

Comment on lines +18 to +21
],
"video": [
"https://www.youtube.com/watch?v=nIAWPQ9-CpU"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
],
"video": [
"https://www.youtube.com/watch?v=nIAWPQ9-CpU"
]
]

That video looks like it's for the "BOSS FX1 LED", which is a different fixture (e.g., it has a laser).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants