Skip to content

Add fixture chauvet-professional/rogue-r3-spot #4828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture chauvet-professional/rogue-r3-spot

Thank you Dario!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Apr 28, 2025
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ chauvet-professional / rogue-r3-spot: d-light / attributes-correctness
  • ✔️ chauvet-professional/rogue-r3-spot-25ch.xml
  • ✔️ chauvet-professional/rogue-r3-spot-19ch.xml
chauvet-professional / rogue-r3-spot: dmxcontrol3 / channel-numbers
  • ❌ chauvet-professional-rogue-r3-spot-25ch.xmlChannel 11 "Rotating Gobo Wheel" is missing capabilities. Used ranges: 0…63, 120…255
    Channel 13 "Static gobo wheel" is missing capabilities. Used ranges: 0…63, 121…255
  • ❌ chauvet-professional-rogue-r3-spot-19ch.xmlChannel 10 "Rotating Gobo Wheel" is missing capabilities. Used ranges: 0…63, 120…255
    Channel 12 "Static gobo wheel" is missing capabilities. Used ranges: 0…63, 121…255
✔️ chauvet-professional / rogue-r3-spot: dragonframe / json-schema-conformity
  • ✔️ chauvet-professional/rogue-r3-spot.json
  • ✔️ manufacturers.json
✔️ chauvet-professional / rogue-r3-spot: millumin / json-schema-conformity
  • ✔️ chauvet-professional/rogue-r3-spot.json
✔️ chauvet-professional / rogue-r3-spot: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Chauvet-Professional-Rogue-R3-Spot.qxf
✔️ chauvet-professional / rogue-r3-spot: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Chauvet-Professional-Rogue-R3-Spot.qxf

Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wheels on this were pretty messed up, and this fixture has a lot of wheels. I've reviewed it as far as the color wheels, but haven't gotten to the gobo wheel modes yet. I don't know when I'm going to get around to that, so here's a partial review.

Comment on lines +236 to +271
},
{
"type": "Gobo",
"name": "Gobo 8 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 7 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 6 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 5 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 4 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 3 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 2 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 1 shaking, slow to fast"
},
{
"type": "Open"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},
{
"type": "Gobo",
"name": "Gobo 8 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 7 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 6 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 5 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 4 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 3 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 2 shaking, slow to fast"
},
{
"type": "Gobo",
"name": "Gobo 1 shaking, slow to fast"
},
{
"type": "Open"
}
}

Comment on lines +38 to +113
"Color Wheel": {
"slots": [
{
"type": "Color",
"name": "White"
},
{
"type": "Color",
"name": "CTO3200K"
},
{
"type": "Color",
"name": "CTO 5600K"
},
{
"type": "Color",
"name": "Green"
},
{
"type": "Color",
"name": "UV"
},
{
"type": "Color",
"name": "Orange"
},
{
"type": "Color",
"name": "Pink"
},
{
"type": "Color",
"name": "Light blue"
},
{
"type": "Color",
"name": "White + CTO 3200K"
},
{
"type": "Color",
"name": "CTO 3200K + CTO 5600K"
},
{
"type": "Color",
"name": "CTO 5600K + Green"
},
{
"type": "Color",
"name": "Green + UV"
},
{
"type": "Color",
"name": "UV + Orange"
},
{
"type": "Color",
"name": "Orange + Pink"
},
{
"type": "Color",
"name": "Pink + Light blue"
},
{
"type": "Color",
"name": "Light blue + White"
},
{
"type": "Color",
"name": "Clockwise color scroll, slow to fast"
},
{
"type": "Color",
"name": "Counterclockwise color scroll, slow to fast"
}
]
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Color Wheel": {
"slots": [
{
"type": "Color",
"name": "White"
},
{
"type": "Color",
"name": "CTO3200K"
},
{
"type": "Color",
"name": "CTO 5600K"
},
{
"type": "Color",
"name": "Green"
},
{
"type": "Color",
"name": "UV"
},
{
"type": "Color",
"name": "Orange"
},
{
"type": "Color",
"name": "Pink"
},
{
"type": "Color",
"name": "Light blue"
},
{
"type": "Color",
"name": "White + CTO 3200K"
},
{
"type": "Color",
"name": "CTO 3200K + CTO 5600K"
},
{
"type": "Color",
"name": "CTO 5600K + Green"
},
{
"type": "Color",
"name": "Green + UV"
},
{
"type": "Color",
"name": "UV + Orange"
},
{
"type": "Color",
"name": "Orange + Pink"
},
{
"type": "Color",
"name": "Pink + Light blue"
},
{
"type": "Color",
"name": "Light blue + White"
},
{
"type": "Color",
"name": "Clockwise color scroll, slow to fast"
},
{
"type": "Color",
"name": "Counterclockwise color scroll, slow to fast"
}
]
},
"Color Wheel 1": {
"slots": [
{
"type": "Open"
},
{
"type": "Color",
"name": "Yellow"
},
{
"type": "Color",
"name": "Light blue"
},
{
"type": "Color",
"name": "Green"
},
{
"type": "Color",
"name": "Red"
},
{
"type": "Color",
"name": "Magenta"
},
{
"type": "Color",
"name": "Dark blue"
},
{
"type": "Color",
"name": "Orange"
}
]
},
"Color Wheel 2": {
"slots": [
{
"type": "Open"
},
{
"type": "Color",
"name": "CTO 3200K"
},
{
"type": "Color",
"name": "CTO 5600K"
},
{
"type": "Color",
"name": "Green"
},
{
"type": "Color",
"name": "UV"
},
{
"type": "Color",
"name": "Orange"
},
{
"type": "Color",
"name": "Pink"
},
{
"type": "Color",
"name": "Light blue"
}
]
},

Comment on lines +4 to +5
"shortName": "Rogue R3",
"categories": ["Moving Head", "Color Changer", "Dimmer", "Effect", "Strobe"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"shortName": "Rogue R3",
"categories": ["Moving Head", "Color Changer", "Dimmer", "Effect", "Strobe"],
"categories": ["Moving Head", "Color Changer"],

There's other Rogue R3 variants, and I'm not aware of this one in particular being shortened to "R3".

"createDate": "2025-04-28",
"lastModifyDate": "2025-04-28"
},
"comment": "19Ch, 25Ch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"comment": "19Ch, 25Ch",

},
"modes": [
{
"name": "Rogue R3 Spot 25ch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Rogue R3 Spot 25ch",
"name": "25 channel",

Comment on lines +857 to +858
"distanceStart": "far",
"distanceEnd": "far",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems odd but I'm not sure of a better way to mark it in OFL. Suggestions welcome.

{
"dmxRange": [152, 163],
"type": "Focus",
"distance": "7m"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"distance": "7m"
"distance": "7m",
"comment": "rotating gobo wheel"

{
"dmxRange": [188, 199],
"type": "Focus",
"distance": "10m"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"distance": "10m"
"distance": "10m",
"comment": "rotating gobo wheel"

{
"dmxRange": [212, 227],
"type": "Focus",
"distance": "20m"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"distance": "20m"
"distance": "20m",
"comment": "rotating gobo wheel"

"dmxRange": [228, 255],
"type": "Focus",
"distanceStart": "far",
"distanceEnd": "far"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"distanceEnd": "far"
"distanceEnd": "far",
"comment": "Autofocus (rotating gobo wheel)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants