Repository navigation
Conversation
Addresses the review on OpenLightingProject#3724: both modes complete, with pan 0-540 and tilt 0-180 degrees, ShutterStrobe and Maintenance types, Color Changer category, no RDM IDs, physical properties taken from the manual, added links to video/manual/product, fixed the manufacturer's name and website. I checked the manual against a fixture (menu settings PA54, Ti27) to see what it actually does. Where my fixture differs from the manual and values I tested: - 9-channel master: off 0-7, dimming 8-134, strobe 135-239, on 240-255. The manual prints 0-8, 8-135, 136-240, and 241-255 ("Power ON/OFF"). The 14-channel dimmer/strobe matches the manual and behaves the same. - 14-channel dimmer/strobe 0-7: light off, where the manual says "No Effect". - 14-channel reset: 150, 175, and 200 reset; 201 and 255 do not. The manual prints 150-255. Both modes 150-200 appear to trigger a reset. The reset fires once on entering the range, then the head resumes whatever is being sent on other channels. - 14-channel ch-11 colour assortments: 0-7 shows the colour channels colour, not a preset. 8-231 sweeps smoothly through colours (loose description by eye: yellow-green, orange, red, magenta, violet, blue, cyan, green, white, lavender, violet) rather than the 17 fixed "Color Assortments" printed. 232-255 ("Color Saltus") jumps between colours. - 14 channel ch12 Colour Speed from about one jump every 2-3s at 0 to about 3 a second at 255. - Pan/tilt speed (9 channel ch 8, 14 channel ch 5): 0 is fastest, 255 slowest.
jamesfry
marked this pull request as ready for review
October 9, 2026 23:10
Author
|
The only failing check seems to be a dead link in OFL's README, outside this change. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the review on #3724: both modes complete, with pan 0-540 and tilt 0-180 degrees, ShutterStrobe and Maintenance types, Color Changer category, no RDM IDs, physical properties taken from the manual, added links to video/manual/product, fixed the manufacturer's name and website.
I checked the manual against a fixture (menu settings PA54, Ti27) to see what it actually did.
Where my fixture differs from the manual and values I tested:
9-channel master: off 0-7, dimming 8-134, strobe 135-239, on 240-255.
The manual prints 0-8, 8-135, 136-240, and 241-255 ("Power ON/OFF").
The 14-channel dimmer/strobe matches the manual and behaves the same.
14-channel dimmer/strobe 0-7: light off, where the manual says "No Effect".
14-channel reset: 150, 175, and 200 reset; 201 and 255 do not. The manual prints 150-255. Both modes 150-200 appear to trigger a reset. The reset fires once on entering the range, then the head resumes whatever is being sent on other channels.
14-channel ch-11 colour assortments: 0-7 shows the colour channels colour, not a preset.
8-231 sweeps smoothly through colours (loose description by eye: yellow-green, orange, red, magenta, violet, blue, cyan, green, white, lavender, violet) rather than the 17 fixed "Color Assortments" printed.
232-255 ("Color Saltus") jumps between colours.
14 channel ch12 Colour Speed from about one jump every 2-3s at 0 to about 3 a second at 255.
Pan/tilt speed (9 channel ch 8, 14 channel ch 5): 0 is fastest, 255 slowest.