Skip to content

fix some 'undefined array key' warnings #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

fix some 'undefined array key' warnings #4121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ddf0821
fix some 'undefined array key' warnings
alexh-swdev Jul 26, 2024
25a2871
c&p...
alexh-swdev Jul 26, 2024
58ddb3e
changed 'isset' to 'array_key_exists'
alexh-swdev Jul 26, 2024
51e8caa
')'issue
alexh-swdev Jul 26, 2024
0a70ee9
fix php cs fixer complain
alexh-swdev Jul 26, 2024
4d015c8
exchange " for '
alexh-swdev Jul 27, 2024
ef4b882
Merge branch 'OpenMage:main' into main
alexh-swdev Jul 29, 2024
c900e8d
Merge branch 'main' into main
alexh-swdev Jul 29, 2024
4902d9a
Merge branch 'main' into main
alexh-swdev Jul 30, 2024
7ed177c
Merge branch 'main' into main
alexh-swdev Aug 1, 2024
0ff1092
fix "must be an array"
alexh-swdev Aug 6, 2024
98d1ea0
Merge branch 'main' of github.com:alexh-swdev/magento-lts
alexh-swdev Aug 6, 2024
876c9cb
Unify quotations, really don't use an undefined array key in _renderO…
alexh-swdev Aug 8, 2024
0e08f2f
Merge branch 'main' into main
alexh-swdev Aug 8, 2024
a5ce782
fix remarks from php stan
alexh-swdev Aug 8, 2024
6b76655
Update Field.php, use single quote.
kiatng Aug 9, 2024
b702e78
Update Select.php, use single quote.
kiatng Aug 9, 2024
bc26da0
Merge branch 'main' into main
sreichel Sep 10, 2024
3cf1662
Merge branch 'main' into main
sreichel Dec 25, 2024
cf265cc
Merge branch 'main' into main
sreichel Jan 11, 2025
39e0380
Merge branch 'main' into main
sreichel Jan 11, 2025
329d5d9
Merge branch 'main' into main
sreichel Jan 18, 2025
e02f853
Merge branch 'main' into main
sreichel Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ public function render(Varien_Data_Form_Element_Abstract $element)
$defTextArr = [];
foreach ($options as $k => $v) {
if ($isMultiple) {
if (is_array($v['value']) && in_array($k, $v['value'])) {
if (array_key_exists('value', $v) && is_array($v['value']) && in_array($k, $v['value'])) {
$defTextArr[] = $v['label'];
}
} elseif (isset($v['value'])) {
} elseif (is_array($v) && array_key_exists('value', $v)) {
if ($v['value'] == $defText) {
$defTextArr[] = $v['label'];
break;
Expand Down
13 changes: 11 additions & 2 deletions app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Select.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,16 @@ protected function _getOptions()
*/
protected function _renderOption($option, $value)
{
$selected = (($option['value'] == $value && (!is_null($value))) ? ' selected="selected"' : '');
if (!array_key_exists('value', $option)) {
if (!array_key_exists('label', $option)) {
return '';
}

$lbl = $this->escapeHtml($option['label']); // or just empty as well?
return '<option value="' . $lbl . '">' . $lbl . '</option>';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for setting label (instead of empty string) to option value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it, so each option has a different / its own value, what the 'value' key in the map was supposed to provide.
If you think that's not required, we can leave the value attribute of the tag empty.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer an empty string.

Maybe you can share the extension that causes the problem, to reproduce it?

Copy link
Contributor Author

@alexh-swdev alexh-swdev Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll change it to empty string then.
It's an Amazon Pay add-on from creative style. I hope I can provide it in the next days

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe its better to fix the extension itself. There some forks of it ...

https://github.com/kirchbergerknorr/magento1_creativestyle_amazon-payments
https://github.com/mothership-gmbh/magento1_creativestyle_amazon_payments

Or create a repo, or better update https://github.com/OpenMageModuleFostering/creativestyle_amazonpayments

}

$selected = (!is_null($value) && ($option['value'] == $value)) ? ' selected="selected"' : '';
return '<option value="' . $this->escapeHtml($option['value']) . '"' . $selected . '>' . $this->escapeHtml($option['label']) . '</option>';
}

Expand All @@ -67,7 +76,7 @@ public function getHtml()
$html = '<select name="' . $this->_getHtmlName() . '" id="' . $this->_getHtmlId() . '" class="no-changes">';
$value = $this->getValue();
foreach ($this->_getOptions() as $option) {
if (is_array($option['value'])) {
if (array_key_exists('value', $option) && is_array($option['value'])) {
$html .= '<optgroup label="' . $this->escapeHtml($option['label']) . '">';
foreach ($option['value'] as $subOption) {
$html .= $this->_renderOption($subOption, $value);
Expand Down
Loading