-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Modulize OpenMage #4618
Draft
sreichel
wants to merge
15
commits into
OpenMage:main
Choose a base branch
from
sreichel:moulize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: Modulize OpenMage #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- re-add removed modules?
|
# Conflicts: # composer.json # composer.lock
Modules
DDEV/bash command
|
Manual steps to test
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
I wanted to modulize OM since a long time b/c you not always need every module. The only way was was/is to disbale in xml-config file or disable output via admin setting - but the code is still there.
How about having modules for erverthing (like M2)?
I have started this two years ago, but never finished. Now, working again on it, it seem to be nealy done.
This PR
Todo;
* some repos need be be restored after yesterday, but a working one ... https://github.com/openmage-strict/module-catalog
Related Pull Requests
Mage_Api
blocks #4262This PR targets to remove dependencies.
Manual testing scenarios (*)
ddev openmage-mono -d
to download all modules to.localdev/
Questions or comments
How it works?
I have prepared every "Mage-module" and added ...
Once git-cloned all modules to
.localdev
run the composer script.It reads the modman-file, search the files in any target-path (app/code,lib, ...) and copies back to
.localdev/<moudule>
.All i have to to is to automate to push changes to single repos and tag releases when required.