Skip to content

PhpStan: some fixes #4705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
May 7, 2025
Merged

PhpStan: some fixes #4705

merged 24 commits into from
May 7, 2025

Conversation

sreichel
Copy link
Contributor

Some progress here ... :)

@sreichel sreichel changed the title - PhpStan: some fixes PhpStan: some fixes Mar 15, 2025
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: lib/Varien Relates to lib/Varien Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml Component: Weee Relates to Mage_Weee Component: Tax Relates to Mage_Tax Component: Index Relates to Mage_Index Component: Api2 Relates to Mage_Api2 Component: Install Relates to Mage_Install Component: lib/* Relates to lib/* phpstan phpunit labels Mar 15, 2025
@sreichel sreichel added the chore label Mar 15, 2025
kiatng
kiatng reviewed Mar 17, 2025
View reviewed changes
@github-actions github-actions bot added Component: Reports Relates to Mage_Reports Template : rwd Relates to rwd template Template : base Relates to base template labels Mar 23, 2025
@github-actions github-actions bot added Component: CatalogRule Relates to Mage_CatalogRule Component: Wishlist Relates to Mage_Wishlist Component: Widget Relates to Mage_Widget Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogSearch Relates to Mage_CatalogSearch Component: Authorizenet Relates to Mage_Authorizenet labels Mar 29, 2025
@github-actions github-actions bot added the Component: lib/Mage Relates to lib/Mage label Apr 6, 2025
@sreichel
Merge branch 'main' into phpstan-1
94132dc 
# Conflicts:
#	.phpstan.dist.baseline.neon
@github-actions github-actions bot removed the composer Relates to composer.json label Apr 6, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
4 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarQube Cloud

@sreichel
Copy link
Contributor Author

160 files looks big and hard to review, but its not.

90% are docblock fixes.

Code changes are mostly adding isset checks, or set a default variale to avoid possible undined variables - a PhpStan level 1 check i wanted to have fixed even it was anoying.

(btw to review ... use the checkox for files you already have reviewed to do it in chunks)

@sreichel
Copy link
Contributor Author

?

addison74
addison74 previously approved these changes Apr 23, 2025
View reviewed changes
@sreichel sreichel added this to the 20.14.0 milestone May 5, 2025
colinmollenhour
colinmollenhour approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking so clean!! 🌟

@colinmollenhour colinmollenhour merged commit 11a4abf into OpenMage:main May 7, 2025
21 checks passed
fballiano added a commit to MahoCommerce/maho that referenced this pull request May 7, 2025
@fballiano
OM PR 4705
61b1d35 
OpenMage/magento-lts#4705
@sreichel
Copy link
Contributor Author

sreichel commented May 7, 2025

Thanks for merging 🙏

In numbers: with phpstan level 5 we started with +11k baselined errors.

Now (some errors are ignored atm) we are below 1.5k!

(IICR M2 is not even close to pass level 2 (?))

@sreichel sreichel deleted the phpstan-1 branch May 7, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng left review comments

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@addison74 addison74 addison74 approved these changes

Assignees
No one assigned
Labels
chore Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Cron Relates to Mage_Cron Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: GoogleAnalytics Relates to Mage_GoogleAnalytics Component: Index Relates to Mage_Index Component: Install Relates to Mage_Install Component: lib/Mage Relates to lib/Mage Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Log Relates to Mage_Log Component: Media Relates to Mage_Media Component: PayPal Relates to Mage_Paypal Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Sales Relates to Mage_Sales Component: Shipping Relates to Mage_Shipping Component: Tax Relates to Mage_Tax Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee Component: Widget Relates to Mage_Widget Component: Wishlist Relates to Mage_Wishlist phpstan phpunit Template : base Relates to base template Template : rwd Relates to rwd template
Projects
None yet
Milestone
20.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @colinmollenhour @kiatng @addison74