-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODE_OF_CONDUCT.md #4733
Open
colinmollenhour
wants to merge
1
commit into
main
Choose a base branch
from
colin-coc-patch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -31,6 +31,27 @@ Examples of unacceptable behavior by participants include: | |||||
* Other conduct which could reasonably be considered inappropriate in a | ||||||
professional setting | ||||||
|
||||||
### Attribution to others | ||||||
|
||||||
We expect all contributors to provide appropriate attribution to others in appreciation | ||||||
for work performed or ideas inspired by other members of the OpenMage or other communities. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot:
Suggested change
|
||||||
|
||||||
When creating a Pull Request or otherwise representing work or ideas to the community, | ||||||
if the work includes substantial code or inspiration leading directly to the authorship | ||||||
of specific lines of code taken from reading PRs, blog posts, release notes, etc. from | ||||||
another project (in particular Maho Commerce), website or other source, a mention must | ||||||
be made in the PR description or equivalent. The definition of "substantial" shall be | ||||||
as little as one line of code - if it's worth creating a commit and pull request for, | ||||||
it will be considered substantial. | ||||||
|
||||||
For example: | ||||||
|
||||||
> Credit for prior work inspiration to {ref} | ||||||
|
||||||
Additionally, if the file that the code was copied from or heavily inspired by, in whole | ||||||
or in part, contains a copyright notice on a single line, that line must also be copied | ||||||
to the corresponding file in OpenMage, even if the filenames are slightly different. | ||||||
|
||||||
## Our Responsibilities | ||||||
|
||||||
Project maintainers are responsible for clarifying the standards of acceptable | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot:
The subheading "### Attribution to others" could be improved by capitalizing the main words for consistency with title case. The corrected version would be "### Attribution to Others".