Skip to content

Varien: add Template Params to Varien_Data_Collection #5259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Hanmac wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Varien: add Template Params to Varien_Data_Collection #5259

Hanmac wants to merge 6 commits into from

Conversation

@Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Jan 29, 2026

Description (*)

Related Pull Requests

  • see OpenMage/magento-lts#<issue_number>

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

probably need to add more collections, i was first testing them on the ones that have getItems() or getItemById()

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@Hanmac Hanmac requested review from addison74 and sreichel January 29, 2026 13:10
@github-actions github-actions bot added Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: Tag Relates to Mage_Tag Component: Admin Relates to Mage_Admin Component: Wishlist Relates to Mage_Wishlist Component: Tax Relates to Mage_Tax Component: Review Relates to Mage_Review Component: Rating Relates to Mage_Rating Component: Newsletter Relates to Mage_Newsletter Component: Bundle Relates to Mage_Bundle Component: Directory Relates to Mage_Directory Component: lib/* Relates to lib/* labels Jan 29, 2026
@Hanmac Hanmac marked this pull request as draft January 29, 2026 14:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 29, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Hanmac Hanmac mentioned this pull request Jan 29, 2026
Merged
3 tasks
@Hanmac
Copy link
Contributor Author

Hanmac commented Jan 30, 2026

i don't really get what is wrong there,
https://psalm.dev/r/56f295c008
and
https://phpstan.org/r/de227244-e131-496f-a34e-3dba1660d686
both find no errors in my example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sreichel sreichel Awaiting requested review from sreichel

@addison74 addison74 Awaiting requested review from addison74

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Component: Admin Relates to Mage_Admin Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Eav Relates to Mage_Eav Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Newsletter Relates to Mage_Newsletter Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Sales Relates to Mage_Sales Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Wishlist Relates to Mage_Wishlist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feat] PHPStan Templates for Varien_Data_Collection

1 participant

@Hanmac