phpstan: variable.implicitArray by sreichel · Pull Request #5551 · OpenMage/magento-lts

sreichel · 2026-04-29T00:13:07Z

Description (*)

Minor phpstan fixes.

Copilot

Pull request overview

This PR applies minor PHPStan-driven fixes by eliminating implicit array creation and a few related baseline suppressions across core, lib, and template code.

Changes:

Initialize variables as arrays before assigning offsets to satisfy variable.implicitArray.
Harden Varien_Object::_addFullNames() against non-array _data to avoid invalid array operations.
Remove PHPStan baseline entries/files that are no longer needed after the fixes (including class name case ignore).

Reviewed changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
lib/Varien/Object.php	Adds array-type guards before sync-field mapping to avoid invalid array operations.
lib/Varien/Io/File.php	Initializes `$owner/$group/$world` arrays before offset assignment in permission parsing.
app/design/frontend/base/default/template/paypal/payment/redirect.phtml	Updates docblock class references to correct case used in codebase and removes related baseline need.
app/code/core/Mage/Sales/Model/Order/Pdf/Shipment.php	Initializes `$lines` before nested offset usage in header rendering.
app/code/core/Mage/Sales/Model/Order/Pdf/Invoice.php	Initializes `$lines` before nested offset usage in header rendering.
app/code/core/Mage/Sales/Model/Order/Pdf/Creditmemo.php	Initializes `$lines` before nested offset usage in header rendering.
app/code/core/Mage/Paygate/controllers/Authorizenet/PaymentController.php	Initializes `$result` before setting result keys in cancel action.
app/code/core/Mage/Paygate/controllers/Adminhtml/Paygate/Authorizenet/PaymentController.php	Initializes `$result` before setting result keys in cancel action.
app/code/core/Mage/Page/Block/Html/Toplinks.php	Initializes `$toplinkInfo` before populating it.
app/code/core/Mage/Newsletter/Model/Resource/Subscriber.php	Initializes `$data` before populating update payload.
app/code/core/Mage/Downloadable/Model/Resource/Link.php	Initializes `$dataToInsert` before population.
app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php	Initializes `$value` before writing nested option structure.
app/code/core/Mage/Core/Model/File/Validator/AvailablePath.php	Initializes `$options` before setting `file_mask`.
app/code/core/Mage/Cms/Model/Resource/Page/Collection.php	Initializes `$data` before setting `value/label`.
app/code/core/Mage/Checkout/controllers/OnepageController.php	Initializes `$result` early for consistent array usage.
app/code/core/Mage/CatalogIndex/Model/Resource/Indexer/Minimalprice.php	Initializes `$conditions` before appending SQL conditions.
app/code/core/Mage/CatalogIndex/Model/Resource/Indexer/Abstract.php	Initializes `$conditions` before appending SQL conditions.
app/code/core/Mage/CatalogIndex/Model/Indexer/Minimalprice.php	Initializes `$data` and `$search` arrays before offset assignment.
app/code/core/Mage/Catalog/Model/Resource/Product.php	Initializes `$updateCond` before appending conditions.
app/code/core/Mage/Catalog/Model/Product/Image.php	Initializes `$path` prior to usage to satisfy PHPStan (see review nit).
app/code/core/Mage/Catalog/Model/Layer/Filter/Item.php	Initializes `$params` before setting URL generation flags.
app/code/core/Mage/Catalog/Block/Layer/State.php	Initializes `$params` before setting URL generation flags.
app/code/core/Mage/Bundle/Block/Catalog/Product/View/Type/Bundle.php	Ensures `$defaultValues` is always defined and reorders a couple initializations.
app/code/core/Mage/Adminhtml/controllers/TagController.php	Initializes `$data` before offset assignment; tightens return docblock.
app/code/core/Mage/Adminhtml/controllers/Catalog/CategoryController.php	Initializes `$params` before use.
app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Form.php	Initializes `$data` before building URL params.
app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php	Initializes `$data` before building URL params; removes stray whitespace line.
app/code/core/Mage/Adminhtml/Block/Newsletter/Template/Grid/Renderer/Action.php	Initializes `$actions` before conditional pushes.
app/code/core/Mage/Adminhtml/Block/Catalog/Helper/Form/Wysiwyg/Content.php	Initializes `$config` before nested offset assignment.
.phpstan.dist.baselines/variable.undefined.php	Removes baseline entry now fixed in bundle JSON config logic.
.phpstan.dist.baselines/variable.implicitArray.php	Removes many no-longer-needed ignores after explicit array initialization.
.phpstan.dist.baselines/offsetAccess.notFound.php	Removes baseline entry now handled by guards in `Varien_Object`.
.phpstan.dist.baselines/empty.notAllowed.php	Updates ignore count after reducing one `empty()` usage.
.phpstan.dist.baselines/class.nameCase.php	Removes obsolete baseline file (now fixed in template docblock).
.phpstan.dist.baselines/argument.type.php	Removes obsolete baseline entry after guarding array usage in `Varien_Object`.
.phpstan.dist.baselines/_loader.php	Stops loading the removed `class.nameCase` baseline file.

Hanmac · 2026-04-29T08:03:10Z

+        $params                 = [];
        $params['_current']     = true;
        $params['_use_rewrite'] = true;
        $params['_query']       = $filterState;
        $params['_escape']      = true;
+


Wouldn't it be better to have $params = [ ... ]?

with [ ... ] being a Multiline Array?

Or better return Mage::getUrl('*/*/*', [ ... ]);

I think this will be to much work.

Lets keep it simple.

@sreichel i meant to write the params array like this:

$params = [ '_current' => true, '_use_rewrite' => true, '_query' => $filterState, '_escape' => true, ];

or like this:

return Mage::getUrl('*/*/*', [ '_current' => true, '_use_rewrite' => true, '_query' => $filterState, '_escape' => true, ]);

i found a rector for similar stuff, but not quite the right thing:
https://getrector.com/rule-detail/inline-array-return-assign-rector

Edit: i asked if there is an extra rule: rectorphp/rector#9747
there isn't one right now

Yeah, to automate it, but atm i dont wont to spent much time for writing rules.

(there should be some project/OM-related rules first e.g. change to getDataById())

btw ... we also have CodeSniffer/Beatifier, cs-fixer with additional ECS rules, but no one covers this

Copilot

Pull request overview

Copilot reviewed 49 out of 49 changed files in this pull request and generated 3 comments.

            if ($this->getHelper()->isPriceGlobal()) {
                $websiteId = 0;
            } else {
                $websiteId = (int) Mage::app()->getStore($this->getStoreId())->getWebsiteId();
+                $pricing = [];
                $pricing[$websiteId] = [];
            }


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…xid-1

Copilot

Pull request overview

Copilot reviewed 107 out of 107 changed files in this pull request and generated 83 comments.

+        $path = [];
+
        $path = [
            self::$_baseMediaPath,
            'cache',
            Mage::app()->getStore()->getId(),
            $path[] = $this->getDestinationSubdir(),
        ];


# Conflicts: # .phpstan.dist.baselines/notEqual.notAllowed.php # app/design/frontend/base/default/template/paypal/payment/redirect.phtml

sonarqubecloud · 2026-05-22T15:52:54Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.6% Duplication on New Code

See analysis details on SonarQube Cloud

sreichel added 2 commits April 29, 2026 02:08

phpstan: variable.implicitArray

9fa62e2

phpstan: variable.implicitArray (1)

a769881

Copilot AI review requested due to automatic review settings April 29, 2026 00:13

sreichel added the chore label Apr 29, 2026

Copilot started reviewing on behalf of sreichel April 29, 2026 00:13 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread app/code/core/Mage/Catalog/Model/Product/Image.php

sreichel requested a review from Hanmac April 29, 2026 00:24

Hanmac reviewed Apr 29, 2026

View reviewed changes

sreichel changed the title ~~phpstan: variable.implicitArray (1)~~ phpstan: variable.implicitArray May 1, 2026

Merge branch 'main' into phpstan/mixid-1

450dce8

github-actions Bot added the phpstan label May 4, 2026

sreichel added this to the 20.19.0 milestone May 4, 2026

Merge branch 'main' into phpstan/mixid-1

5265bc9

sreichel requested a review from Copilot May 6, 2026 22:35

Copilot started reviewing on behalf of sreichel May 6, 2026 22:35 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

sreichel and others added 4 commits May 7, 2026 00:42

Potential fix for pull request finding

2e8b3dd

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

typo

0b0e68f

Merge remote-tracking branch 'origin/phpstan/mixid-1' into phpstan/mi…

d39cc26

…xid-1

update

b0b471a

github-actions Bot added Component: Reports Relates to Mage_Reports Component: Customer Relates to Mage_Customer Component: Wishlist Relates to Mage_Wishlist Component: Review Relates to Mage_Review Component: Index Relates to Mage_Index labels May 7, 2026

sreichel marked this pull request as draft May 7, 2026 03:37

update

cda4292

github-actions Bot added Component: CatalogRule Relates to Mage_CatalogRule Component: Payment Relates to Mage_Payment labels May 7, 2026

sreichel changed the title ~~phpstan: variable.implicitArray~~ phpstan: docblock-update May 7, 2026

sreichel changed the title ~~phpstan: docblock-update~~ phpstan: variable.implicitArray May 7, 2026

cs

04a6e99

sreichel marked this pull request as ready for review May 7, 2026 21:25

sreichel requested a review from Copilot May 7, 2026 21:26

Copilot started reviewing on behalf of sreichel May 7, 2026 21:27 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

sreichel marked this pull request as draft May 7, 2026 21:44

sreichel added 2 commits May 7, 2026 23:48

typos

e7ad773

docs

be99a68

sreichel marked this pull request as ready for review May 8, 2026 17:32

sreichel added 2 commits May 22, 2026 17:41

Merge branch 'main' into phpstan/mixid-1

3b18b3e

# Conflicts: # .phpstan.dist.baselines/notEqual.notAllowed.php # app/design/frontend/base/default/template/paypal/payment/redirect.phtml

update

176d0f3

Uh oh!

Conversation

sreichel commented Apr 29, 2026

Description (*)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Hanmac Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

sreichel Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Hanmac Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sreichel May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 22, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hanmac Apr 30, 2026 •

edited

Loading