Varien Gd2: fix isset check#5605
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates Varien_Image_Adapter_Gd2::save() to simplify redundant isset()/!isset() branches, addressing a PHPStan “isset.variable” warning and allowing removal of the corresponding baseline entry.
Changes:
- Simplified the
save()parameter-branching logic by removing conditions that are implied by earlierelseifbranches. - Deleted the dedicated PHPStan baseline for the redundant
isset()warning. - Removed the deleted baseline file from the PHPStan baseline loader.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/Varien/Image/Adapter/Gd2.php |
Simplifies elseif conditions in save() to avoid redundant isset() checks. |
.phpstan.dist.baselines/isset.variable.php |
Removes the no-longer-needed PHPStan ignore entry for the fixed isset() warning. |
.phpstan.dist.baselines/_loader.php |
Drops the include for the removed isset.variable.php baseline file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description (*)
cherry-pick
issetcheck in Gd2Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)