Skip to content

Unify Colors in adminhtml openmage design#5615

Open
B3Hana wants to merge 2 commits into
OpenMage:mainfrom
B3Hana:openmage-design
Open

Unify Colors in adminhtml openmage design#5615
B3Hana wants to merge 2 commits into
OpenMage:mainfrom
B3Hana:openmage-design

Conversation

@B3Hana

@B3Hana B3Hana commented May 28, 2026

Copy link
Copy Markdown
Contributor

Description (*)

The openmage design contains way to many colors, with many being used only once, or just barely different.
It also contains multiple definitions, which are not used anywhere or are doubled.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

check the adminhtml design

Questions or comments

Currently a draft, as I'm not sure what to use to compile the scss without it containing unrelated changes.
I'm currently using sass 1.97.3

initially this was supposed to be an upgrade to add focus colors and such, but with this many colors it needs to be streamlined first. :(
(and selectors reduced, the amount of useless overrides makes it really hard to find the correct selector to update)

new datepicker with openmage blue:
image
new user menu, like the normal navigation:
image
messages:
image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All automated tests passed successfully (all builds are green, SonarCloud checks are not required to merge)

@github-actions github-actions Bot added Template : admin Relates to admin template Component: Adminhtml Relates to Mage_Adminhtml labels May 28, 2026
@B3Hana B3Hana force-pushed the openmage-design branch from 7459af5 to 016ea96 Compare June 1, 2026 08:34
@B3Hana

B3Hana commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

@sreichel do you have an older sass version to compile the css files without unrelated changes?
Otherwise I can compile then but functions like darken would be translated to something like rgb(230.35, 230.35, 230.35) and some changes to how numbers are written.

Buttons now have a consistent hover/focus effect, and get darker not lighter.
I didn't rename the grayscale colors (or removed all color functions) for now, only condensed them .

@B3Hana B3Hana marked this pull request as ready for review June 1, 2026 08:40
@sreichel

sreichel commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@sreichel do you have an older sass version to compile the css files without unrelated changes?

I broke my pc, cant check atm. Ive used compass from https://docs.openmage.org/developers/tools/ddev/#installing-compass

@B3Hana B3Hana force-pushed the openmage-design branch from 016ea96 to b109150 Compare June 4, 2026 11:25
@B3Hana

B3Hana commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

I used the newer version and removed some changes by hand. the replacement of some hex color codes with rgb seems to be on purpose by sass, as converting them back would lose precision. (not really needed for us, but whatever)

The PR is ready to be reviewed.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Adminhtml Relates to Mage_Adminhtml Template : admin Relates to admin template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants