Skip to content

[Sales] add getMailer and Email-Queues#5625

Draft
Hanmac wants to merge 14 commits into
OpenMage:mainfrom
Hanmac:feature/sales_mailer_helper
Draft

[Sales] add getMailer and Email-Queues#5625
Hanmac wants to merge 14 commits into
OpenMage:mainfrom
Hanmac:feature/sales_mailer_helper

Conversation

@Hanmac
Copy link
Copy Markdown
Contributor

@Hanmac Hanmac commented Jun 2, 2026

Description (*)

  • adds getMailer helper function to be easier overwritten.
  • also adds Email-Queue for other Sales related E-Mails.

While touching this part, maybe we could discuss other Sales E-Mails related ideas?

  • like sending Invoice and Shipment E-Mails to their E-Mail in their order_address? (instead/in addition)?

Related Pull Requests

  • see OpenMage/magento-lts#<issue_number>

Fixed Issues (if relevant)

  • fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All automated tests passed successfully (all builds are green, SonarCloud checks are not required to merge)

@Hanmac Hanmac requested a review from sreichel June 2, 2026 15:16
@Hanmac Hanmac added the Component: Sales Relates to Mage_Sales label Jun 2, 2026
@github-actions github-actions Bot added the Component: Payment Relates to Mage_Payment label Jun 3, 2026
@github-actions github-actions Bot added Component: Checkout Relates to Mage_Checkout phpstan labels Jun 3, 2026
@Hanmac
Copy link
Copy Markdown
Contributor Author

Hanmac commented Jun 3, 2026

@sreichel i'm curious about this part:

$paymentBlock = Mage::helper('payment')->getInfoBlock($order->getPayment())

and their ignored errors:

Parameter #1 $info of method Mage_Payment_Helper_Data::getInfoBlock() expects Mage_Payment_Model_Info, Mage_Sales_Model_Order_Payment|false given.

But shouldn't this cause a big PHP Error crash?
Or do i miss something there?

Edit: I'm dumb, Mage_Sales_Model_Order_Payment extends Mage_Payment_Model_Info, it complains about the possible false

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
26.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Checkout Relates to Mage_Checkout Component: Payment Relates to Mage_Payment Component: Sales Relates to Mage_Sales phpstan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant