Skip to content

Add -O2 to flang flags when building on WoA in Release mode #5128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

martin-frbg
Copy link
Collaborator

fixes #5120

@martin-frbg martin-frbg added this to the 0.3.30 milestone Feb 12, 2025
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can't test locally, but should work. I considered whether -O2 should work also with clang-cl (rather than /O2 style flag), and https://flang.llvm.org/docs/FlangCommandLineReference.html#optimization-level says it's always -O2.

@martin-frbg
Copy link
Collaborator Author

LGTM. I can't test locally, but should work. I considered whether -O2 should work also with clang-cl (rather than /O2 style flag), and https://flang.llvm.org/docs/FlangCommandLineReference.html#optimization-level says it's always -O2.

Thanks - I do have the hardware to test, and in fact it was one of the Qualcomm/WoA-associated engineers who raised the issue (mcw=Multicoreware Inc.)

@martin-frbg martin-frbg merged commit 453efbd into OpenMathLib:develop Feb 12, 2025
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Optimizations Flags for Fortran Targets on WoA
2 participants