Skip to content

remove non-vectorized SGEMV transpose reduce path for POWER8, restoring optimizations frpm PR4880 #5238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
+4 −19
Merged

remove non-vectorized SGEMV transpose reduce path for POWER8, restoring optimizations frpm PR4880 #5238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions kernel/power/sgemv_t.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,7 @@ static void sgemv_kernel_4x8(BLASLONG n, BLASLONG lda, FLOAT *ap, FLOAT *x,
temp7 += vx * vva7;
}

#if defined(POWER8)
y[0] += alpha * (temp0[0] + temp0[1] + temp0[2] + temp0[3]);
y[1] += alpha * (temp1[0] + temp1[1] + temp1[2] + temp1[3]);
y[2] += alpha * (temp2[0] + temp2[1] + temp2[2] + temp2[3]);
y[3] += alpha * (temp3[0] + temp3[1] + temp3[2] + temp3[3]);

y[4] += alpha * (temp4[0] + temp4[1] + temp4[2] + temp4[3]);
y[5] += alpha * (temp5[0] + temp5[1] + temp5[2] + temp5[3]);
y[6] += alpha * (temp6[0] + temp6[1] + temp6[2] + temp6[3]);
y[7] += alpha * (temp7[0] + temp7[1] + temp7[2] + temp7[3]);
#else

register __vector float t0, t1, t2, t3;
register __vector float a = {alpha, alpha, alpha, alpha};
__vector float vy0 = vec_vsx_ld(0, y);
Expand Down Expand Up @@ -116,7 +106,7 @@ static void sgemv_kernel_4x8(BLASLONG n, BLASLONG lda, FLOAT *ap, FLOAT *x,
vy1 += a * temp4;
vec_vsx_st(vy0, 0, y);
vec_vsx_st(vy1, 0, &(y[4]));
#endif

}

static void sgemv_kernel_4x4(BLASLONG n, BLASLONG lda, FLOAT *ap, FLOAT *x,
Expand All @@ -143,12 +133,7 @@ static void sgemv_kernel_4x4(BLASLONG n, BLASLONG lda, FLOAT *ap, FLOAT *x,
temp2 += vx * vva2;
temp3 += vx * vva3;
}
#if defined(POWER8)
y[0] += alpha * (temp0[0] + temp0[1] + temp0[2] + temp0[3]);
y[1] += alpha * (temp1[0] + temp1[1] + temp1[2] + temp1[3]);
y[2] += alpha * (temp2[0] + temp2[1] + temp2[2] + temp2[3]);
y[3] += alpha * (temp3[0] + temp3[1] + temp3[2] + temp3[3]);
#else

register __vector float t0, t1, t2, t3;
register __vector float a = {alpha, alpha, alpha, alpha};
__vector float vy0 = vec_vsx_ld(0, y);
Expand All @@ -165,7 +150,7 @@ static void sgemv_kernel_4x4(BLASLONG n, BLASLONG lda, FLOAT *ap, FLOAT *x,

vy0 += a * temp0;
vec_vsx_st(vy0, 0, y);
#endif

}

static void sgemv_kernel_4x2(BLASLONG n, BLASLONG lda, FLOAT *ap, FLOAT *x,
Expand Down
Loading