loongarch64: fix segfaults in copy kernels and adjust dsyrk block size#5942
Open
HecaiYuan wants to merge 4 commits into
Open
loongarch64: fix segfaults in copy kernels and adjust dsyrk block size#5942HecaiYuan wants to merge 4 commits into
HecaiYuan wants to merge 4 commits into
Conversation
On LoongArch LA464 platform, dsyrk produces incorrect results when processing certain block sizes, which in turn causes dcholesky and dpotrf to fail on positive-definite matrices. The issue manifests with specific block dimension combinations (e.g., 80x16). Adjust GEMM_P from 112 to 96 so that dsyrk's blocking logic avoids generating the problematic size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On LA464,
dsyrkproduces incorrect results with specific block dimension combinations (e.g., 80×16), which causesdcholeskyanddpotrfto fail on positive-definite matrices.Reduce
GEMM_Pfrom 112 to 96 for LoongArch64 LA464 double-precision builds, so the blocking logic avoids generating the problematic size.The following minimal C program was used to pinpoint the issue:
Compile and run:
After fix: all diagonal elements remain positive as expected.