search unit tests. Note: current code not checking if grid points satisfy constraints#2
Open
biona001 wants to merge 10 commits intoOpenMendel:masterfrom
Open
search unit tests. Note: current code not checking if grid points satisfy constraints#2biona001 wants to merge 10 commits intoOpenMendel:masterfrom
biona001 wants to merge 10 commits intoOpenMendel:masterfrom
Conversation
unit test complete, NOT checking if grid points satisfies constraints
added test case to show current code does not check whether grid points satisfy constraints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we set travel = grid, then we are basically evaluating the function at a bunch of specified grid points. These grid points MAY NOT satisfy the constraints specified in the problem. Test 13 contains this test case (commented out) and it currently will return the wrong minimum, but it should throw an error saying that some grid points does not satisfy constraints. To fix the issue, I added lines 92~105 to Search.jl (which currently is commented out to prevent unwanted action).