Remove geofence_enabled parameter from configuration files and update…#18
Open
jerinpeter wants to merge 1 commit intomainfrom
Open
Remove geofence_enabled parameter from configuration files and update…#18jerinpeter wants to merge 1 commit intomainfrom
jerinpeter wants to merge 1 commit intomainfrom
Conversation
… person_follow_greet.py to use environment variable for geofence enabling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how the geofence feature is enabled for the person follower module. Instead of configuring geofence enablement through YAML parameters, the setting is now controlled via the
GEOFENCE_ENABLEDenvironment variable. This change improves deployment flexibility by allowing geofence activation to be managed at runtime without editing configuration files.Key changes:
Geofence enablement configuration:
geofence_enabledparameter from all robot-specific YAML config files (go2_params.yaml,g1_params.yaml,tron_params.yaml). [1] [2] [3]geofence_enabledparameter inperson_follow_greet.py.Environment variable integration:
GEOFENCE_ENABLEDas an environment variable in thedocker-compose.ymlservice definition, defaulting tofalse.person_follow_greet.pyto determine if geofencing is enabled by reading theGEOFENCE_ENABLEDenvironment variable, rather than from parameters.