ADD GitHub signin/sign up functionlity to Migration/next #176
Open
m15e wants to merge 6 commits intoOpenMined:migration/nextfrom
Open
ADD GitHub signin/sign up functionlity to Migration/next #176m15e wants to merge 6 commits intoOpenMined:migration/nextfrom
m15e wants to merge 6 commits intoOpenMined:migration/nextfrom
Conversation
tcp
reviewed
Apr 26, 2021
src/pages/signup.tsx
Outdated
| lastName = splitName.length >= 2 ? splitName.slice(1).join(' ') : '' | ||
| } | ||
|
|
||
| const profile = authUser.additionalUserInfo.profile as any |
Collaborator
There was a problem hiding this comment.
Avoid using any here. The type for the profile can be inferred from the lines below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist