feat: add configurable search filters for remote Weaviate datasets#91
Merged
Conversation
- move filters logic to its own seperate file
9759b4f to
b6687df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, flexible filter schema and logic for the Remote Weaviate dataset type, enabling advanced filtering capabilities in search queries. It also improves configuration schema generation for frontend forms, ensures filter validation, and includes minor code cleanups. The most important changes are grouped below:
Weaviate Remote Filtering Enhancements
filters.pydefining filter schemas (FilterCondition,FilterGroup) and logic for constructing Weaviate filter objects, supporting advanced, type-safe, and nested filter conditions. (backend/syft_space/components/dataset_types/weaviate_remote/filters.py)RemoteWeaviateConfigurationto accept afiltersfield, allowing users to specify filters in dataset configuration. (backend/syft_space/components/dataset_types/weaviate_remote/weaviate_type.py)backend/syft_space/components/dataset_types/weaviate_remote/weaviate_type.py) [1] [2] [3] [4]Configuration Schema Generation Improvements
ConfigSchemaGeneratorto preserve$defsin generated schemas, ensuring$refpointers remain valid for frontend dynamic form rendering, rather than inlining all references. (backend/syft_space/components/shared/utils.py) [1] [2]Minor Code Cleanups
marketplaces/handlers.pyandchromadb_type.pyfor clarity and consistency. (backend/syft_space/components/marketplaces/handlers.py[1]backend/syft_space/components/dataset_types/chromadb_local/chromadb_type.py[2]frontend/src/pages/UpdatesPage.vue[1] [2];frontend/src/composables/useDatasetBrowser.ts[3]