Conversation
- go mod tidy adds github.com/Microsoft/go-winio for Windows builds - Add SYFTBOX_ACL_STAGING_GRACE_MS env var to override 10min default - Set 5s grace in TestACLPropagationUpdates so revocation test passes - Update hotlink.md with Go reorder buffer and buffer copy fix status
…upport Rust acl_staging.rs had a hardcoded 10-minute grace period that couldn't be overridden in tests. Now reads SYFTBOX_ACL_STAGING_GRACE_MS (millis) via LazyLock, matching the Go client behavior. CI temporarily limited to acl tests only to save credits while debugging.
Go cleanupEmptyParentDirs had a bug where len(dirEntries) checked the original count after removing .DS_Store/Thumbs.db, so directories with only garbage files were never cleaned up. Both Go and Rust now retry os.Remove/fs::remove_dir 3 times with 50ms delay to handle brief Windows file locks from Explorer/antivirus. CI temporarily limited to go acl windows to test this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist