Skip to content

Conversation

@sjoelund
Copy link
Member

@sjoelund sjoelund commented Jun 7, 2018

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OpenModelica-Hudson
Copy link
Member

@robbr48 We want to be able to check that OMTLMSimulator builds independently of the OMSimulator project, right? Then libxml2 would need to be part of this repository or 3rdParty also part of this repository. Or there needs to be an option to add CPPFLAGS to use the libxml2 from the OS or something. How do you build the stand-alone version?

@robbr48
Copy link
Collaborator

robbr48 commented Oct 1, 2018

I currently don't build OMTLMSimulator as stand-alone from GitHub, but it would be good to test that it is possible. It needs to be compiled as stand-alone in the Beast environment. There libxml2 is already installed in the OS though. So I guess that solution would be the best alternative.

@adrpo
Copy link
Member

adrpo commented Oct 1, 2018

@robbr48: We had Hudson jobs for building OMTLMSimulator standalone but we disabled those. I can revive them, checkout OMSimulator and build just OMTLMSimulator using libxml2 from OMSimulator-3rdParty. Let me know if this would be useful.

@adrpo
Copy link
Member

adrpo commented Oct 1, 2018

@sjoelund, @robbr48: ah, this was about adding it as a pipeline for Jenkins. Then @sjoelund: just checkout OMSimulator, config it and call make OMTLMSimulatorStandalone.

@sjoelund
Copy link
Member Author

sjoelund commented Oct 2, 2018

In order to build it stand-alone it must not depend on being part of another repository. We should be able to test OMTLMSimulator pull requests build/test fine before merging them into OMSimulator.

@robbr48 so if libxml2 is installed in the OS, that's a reasonable option? That's not much to add to a docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants