Skip to content

Commit e8738ae

Browse files
author
Chuck Dumont
authored
Merge pull request #210 from chuckdumont/work
Fix typo in async mode module define template
2 parents 168887d + 34d732f commit e8738ae

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

README.md

+5
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
- [Related plugins](#related-plugins)
4949
- [Sample application](#sample-application)
5050
- [Release Notes](#release-notes)
51+
- [Known Issues](#known-issues)
5152
- [Footnotes](#footnotes)
5253

5354
<!-- TOC END -->
@@ -461,6 +462,10 @@ The versions of Dojo listed below require version 2.1.0 or later of this plugin
461462

462463
In addition, Dojo loaders built with earlier versions of the plugin will not work with 2.1.0 or later, even if you have not changed the version of Dojo you are building with. If you are using a pre-built loader with the [loader](#loader) config option, then you will need to rebuild it when upgrading to 2.1.
463464

465+
# Known Issues
466+
467+
There is a known issue with incrementally upgrading some versions of webpack to newer versions when using this plugin. If, after upgrading webpack, you encounter the error "No hook for resolver normal in object ResolverFactory", try deletig your `node_modules` directory **and** your `package-lock.json` file and running `npm install` again to resolve the issue.
468+
464469
# Footnotes
465470

466471
<a name="foot1">1.</a>&nbsp; Embedded loader sizes are determined using a stand-alone embedded loader that has been uglified and gzipped. The loader was produced as described in [Building the Dojo loader](#building-the-dojo-loader), with [the Dojo config API excluded](#the-dojo-config-api-feature) and using the 2.2.2 version of this plugin and the 1.14 Dojo loader, both of which support the new [`foreign-loader`](https://github.com/dojo/dojo/pull/279) has.js feature conditional. Embedded loader sizes for earlier versions vary depending on the version of this plugin and of Dojo, up to a max of about 4KB when the Dojo config API is included.

lib/DojoAMDDefineDependency.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ DojoAMDDefineDependency.Template = class DojoAMDDefineDependencyTemplate extends
5555
aof: [
5656
"var __WEBPACK_AMD_DEFINE_FACTORY__, __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_RESULT__;",
5757
`!(__WEBPACK_AMD_DEFINE_ARRAY__ = #, __WEBPACK_AMD_DEFINE_FACTORY__ = (#),
58-
__WEBPACK_AMD_DEFINE_RESULT_ = (typeof __WEBPACK_AMD_DEFINE_FACTORY__ === 'function' ?
58+
__WEBPACK_AMD_DEFINE_RESULT__ = (typeof __WEBPACK_AMD_DEFINE_FACTORY__ === 'function' ?
5959
(${djProp}.d(__WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_FACTORY__, module, exports)) : __WEBPACK_AMD_DEFINE_FACTORY__),
6060
module.exports = __WEBPACK_AMD_DEFINE_RESULT__)`
6161
],

0 commit comments

Comments
 (0)