Skip to content

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Oct 6, 2025

This collection uses id for datasetId and this will silently not delete anything when a dataset is removed. Aggregates will then accidentally include removed datasets.

Fixes #3590 and will require a database update to remove the existing failures once this has been deployed.

This results in these datasets being included in queries when they've been deleted.
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 42.93%. Comparing base (ae223fd) to head (6cfa395).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
packages/openneuro-server/src/datalad/dataset.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3594      +/-   ##
==========================================
+ Coverage   41.15%   42.93%   +1.78%     
==========================================
  Files         582      633      +51     
  Lines       31182    33142    +1960     
  Branches     1479     1479              
==========================================
+ Hits        12833    14231    +1398     
- Misses      18210    18772     +562     
  Partials      139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datasets GraphQL resolver can crash if results include deleted datasets accesible to the querying user

1 participant