Skip to content

fix(app): Use recursive: true for native file API downloads - #3909

Merged
nellh merged 1 commit into
masterfrom
3907-recursive-flag-downloads
Apr 23, 2026
Merged

fix(app): Use recursive: true for native file API downloads#3909
nellh merged 1 commit into
masterfrom
3907-recursive-flag-downloads

Conversation

@nellh

@nellh nellh commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Simplify native file API downloads to use the recursive flag and fixes the invalid query structure in #3907

@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 34.14634% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.87%. Comparing base (83699d4) to head (66426b1).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...pp/src/scripts/dataset/download/download-native.js 3.57% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3909      +/-   ##
==========================================
+ Coverage   48.85%   48.87%   +0.02%     
==========================================
  Files         680      680              
  Lines       37686    37665      -21     
  Branches     1867     1867              
==========================================
- Hits        18410    18408       -2     
+ Misses      19117    19098      -19     
  Partials      159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nellh
nellh merged commit 890a10b into master Apr 23, 2026
16 of 17 checks passed
@nellh
nellh deleted the 3907-recursive-flag-downloads branch April 23, 2026 18:14
@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 154 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@openneuro/app-esm 16.13MB -154 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: @openneuro/app-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/dataset-*.js -154 bytes 389.35kB -0.04%

Files in assets/dataset-*.js:

  • ./src/scripts/dataset/download/download-query.js → Total Size: 1.06kB

  • ./src/scripts/dataset/download/download-native.js → Total Size: 3.83kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant