Map information tool: Information about the map properties #2125
Conversation
|
Any proposals for additional features? |
|
For consistent naming, this should probably come as class |
|
Reminder to me: Add new .cpp file to code-check-wrapper.sh |
dl3sdo
force-pushed
the
mapinfo
branch
4 times, most recently
from
b79daf8 to
60d8eba
Compare
|
|
|
Hi, I really appreciate the implementation of Map information tool. I have comments only on the information about the coordinate system, when the info "by EPSG code" is shown. I think this is rather insufficient information and EPSG value + Coordinate system name (zone) should be shown. |
The map information tool informs about the number of map objects, templates and undo-/redo-steps. It informs about the number and names of map parts, symbols, colors, and fonts. It shows for each color the symbol(s) using the color. For each symbol in use the tool shows the used color(s) and the number of related objects. The report can be exported as text file.
|
@krticka: thank you for your feedback. I extended the information about the CRS. However, I don't know how I can easily derive the UTM zone from the EPSG code so I just added the zone or code for UTM, GK and EPSG: |
|
@dl3sdo Thank you for this improvement. Every zone usually has its own EPSG code, so there is no need to bother with it. Information about coordinate system can be easily extended if the code will be active hyperlink to the web EPSG database, e.g. https://epsg.io/25832 |
| QTreeWidgetItem* tree_widget_item; | ||
| if (tree_depth) | ||
| tree_widget_item = new QTreeWidgetItem(tree_item_hierarchy.back()); | ||
| else | ||
| tree_widget_item = new QTreeWidgetItem(map_info_tree); |
There was a problem hiding this comment.
My style would be
auto* tree_widget_item = new QTreeWidgetItem(tree_depth ? tree_widget_itemtree_item_hierarchy.back() : map_info_tree);
And yes, not everyone likes it. :-)
There was a problem hiding this comment.
Especially the compiler does not like it ;-)
I tried that before but had to learn that the compiler apparently wants to know at compile time which constructor to use.
This variation is accepted:
auto* tree_widget_item = tree_depth ? new QTreeWidgetItem(tree_item_hierarchy.back()) : new QTreeWidgetItem(map_info_tree);
There was a problem hiding this comment.
Is that equivalent:
| QTreeWidgetItem* tree_widget_item; | |
| if (tree_depth) | |
| tree_widget_item = new QTreeWidgetItem(tree_item_hierarchy.back()); | |
| else | |
| tree_widget_item = new QTreeWidgetItem(map_info_tree); | |
| auto* tree_widget_item = new QTreeWidgetItem (tree_depth ? tree_item_hierarchy.back() : map_info_tree.invisibleRootItem()); |
|
I incorporated all review comments, please review. |
Move non-GUI code out of dialog. Revise structures and identifiers.
|
Mapper uses default type-specific symbols for objects without specific symbols. Commit 0d2cd01 counts and shows the usage of these default symbols below their symbol category: Maybe we should not show the 'Undefined symbols' category if there are no really 'undefined symbols' as the current output is confusing. |
If a map has a Custom PROJ.4 Crs but no id it will identify as 'Local' instead. Change shown Crs to 'Custom PROJ.4' if the state is Geospatial.
|
The Custom PROJ.4 change was triggered by testing with a map that has this Crs: |
|
I successfully reviewed the code and tested the Windows build as well as my development version with various maps. |
|
Okay, I will "squash and merge" this tonight. |
Use function Symbol::getNumberAndPlainTextName() which was introduced by OpenOrienteeringGH-2125 instead of concatenating symbol number and symbol name.
Use function Symbol::getNumberAndPlainTextName() which was introduced by GH-2125 instead of concatenating symbol number and symbol name.
…ing#2125) Co-authored-by: Kai Pastor <[email protected]>
Co-authored-by: Kai Pastor <[email protected]>
…ing#2125) Co-authored-by: Kai Pastor <[email protected]> [lpechacek] Port to LibreMapper.
Use function Symbol::getNumberAndPlainTextName() which was introduced by OpenOrienteeringGH-2125 instead of concatenating symbol number and symbol name.
4 participants
The map information tool informs about the number of map objects, templates and undo-/redo-steps.
It informs about the number and names of map parts, symbols, colors, and fonts.
It shows for each color the symbol(s) using the color.
For each symbol in use the tools shows the used color(s) and the number of related objects.