feat: enhance plan item management with new functionalities#645
Open
tenkus47 wants to merge 8 commits into
Open
feat: enhance plan item management with new functionalities#645tenkus47 wants to merge 8 commits into
tenkus47 wants to merge 8 commits into
Conversation
Member
tenkus47
commented
May 29, 2026
tenkus47
commented
- Added functions to retrieve plan days by ID with tasks and subtasks, and to delete multiple days by their IDs.
- Introduced request models for creating and deleting days, allowing for batch operations.
- Updated service and view layers to support the new functionalities, including API endpoints for creating and deleting days.
- Enhanced tests to cover the new features and ensure proper functionality.
- Added functions to retrieve plan days by ID with tasks and subtasks, and to delete multiple days by their IDs. - Introduced request models for creating and deleting days, allowing for batch operations. - Updated service and view layers to support the new functionalities, including API endpoints for creating and deleting days. - Enhanced tests to cover the new features and ensure proper functionality.
Confidence Score: 5/5Safe to merge; the logic changes are well-covered by tests and no blocking defects were found in the changed paths. The bulk-update fix, new batch endpoints, and task-copy logic all look correct. Test coverage for the new No files require special attention. Reviews (6): Last reviewed commit: "feat: add function to retrieve plan day ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
- Added logging for integrity errors during plan item saving operations. - Updated HTTP status codes for error responses to align with RESTful standards. - Refactored functions to enhance readability and maintainability, including the introduction of a new helper function for author plan retrieval. - Enhanced test cases to ensure proper error propagation and validate new functionalities.
- Implemented tests for creating plan items with task copying from a source day. - Added tests for deleting plan days and handling unauthorized access. - Introduced tests for reordering days and deleting associated audio files. - Enhanced existing tests to cover edge cases and ensure proper error handling.
- Changed parameter names in the `update_days_in_bulk_by_plan_id` function to improve clarity and consistency. - Updated binding parameters from "id" and "day_number" to "b_id" and "b_day_number" respectively for better context.
- Updated the `_get_author_plan` function to include author ID validation, ensuring that only the correct author can access their plans. - Refactored the plan retrieval logic to use `get_plan_by_id` instead of `get_plan_by_id_and_created_by`, simplifying the function and improving clarity. - Added a new error response for author mismatches to enhance security and user feedback. - Updated tests to reflect changes in the plan retrieval logic and author validation.
- Changed import statements to include new request models for creating and deleting days. - Updated the delete function to support deleting multiple plan days, enhancing functionality.
- Introduced `get_plan_day_by_id_any_plan` to fetch a plan day by its ID, including related tasks and subtasks. - Updated the `create_plan_item` function to utilize the new retrieval method, enhancing cross-plan copying functionality. - Modified tests to ensure proper validation and access control for copying tasks between plans.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.