-
Notifications
You must be signed in to change notification settings - Fork 137
Ghostscript (gstoraster): Introduce cupsHalftoneType dithering algorithms #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks the same as libcupsfilters one - I have the same comments: some code style and request for someone who understands the functionality better.
Either way, thank you for the PR, @ValdikSS ! |
9e5bee7
to
035508c
Compare
Fixed, rebased and force-pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same as libcupsfilters.
035508c
to
394f816
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the change - I have missed one place where we have to guard better against NULL, so it would be great if you looked into that.
394f816
to
40a6d35
Compare
…thms Add new dithering (halftone) algorithms in addition to the default Ghostscript one. Controlled either with `halftone-type` job option or `cupsHalftoneType` PPD option. - Stochastic algotirhm is implemented in `stocht.ps` Ghostscript library, just include it if cupsHalftoneType is set to yes/true/on/stochastic. - Foo2zjs algorithm is a PostScript code taken from foo2zjs-pstops file (don't know the name of the algorithm)
Similar to pdftoraster implementation.
40a6d35
to
48de598
Compare
Removed the stray |
Everything from libcupsfilters MR: OpenPrinting/libcupsfilters#92
Add new dithering (halftone) algorithms in addition to the default Ghostscript one.
Controlled either with
halftone-type
job option orcupsHalftoneType
PPD option.stocht.ps
Ghostscript library, just include it if cupsHalftoneType is set to yes/true/on/stochastic.Default algorithm
Stochastic algorithm
Foo2zjs algorithm