Fix PCLm strip overflow and add regression test #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@N3mes1s Thanks a lot for the detailed report and the fix. I did not see any issue when reviewing the code, but when triggering the CI your test script is failing. @uddhavphatak Please check also the rest of your contributed code. Please avoid hard-coded array sizes or data storage, and avoid string manipulation functions without output size control, like |
The pwgtopdf_doc_t doc structure was declared on the stack without initialization, leaving all fields (including colorProfile) containing random garbage from the stack memory. This caused a crash when: 1. The code at line 1328 checked 'if (doc->colorProfile != NULL)' 2. The uninitialized colorProfile could contain any random value, including non-NULL garbage that looked like a valid pointer 3. When cmsGetColorSpace(doc->colorProfile) was called with this garbage pointer, it caused a segmentation fault The AddressSanitizer test correctly caught this bug: AddressSanitizer: SEGV on unknown address 0x000000000051 #0 in cmsGetColorSpace OpenPrinting#1 in prepare_pdf_page cupsfilters/pwgtopdf.c:1328 Fix: Add memset(&doc, 0, sizeof(doc)) to zero-initialize all fields before use, ensuring colorProfile and other pointers start as NULL. This allows the test-pclm-overflow.sh regression test to pass.
Contributor
Author
|
@tillkamppeter Yeah no issue at all! Was testing a new project i'm working on and found this issue and fixed as well! Was possing locally because i had that lib compiled from other tests! Now it should be fixed. I found another un-initialized memory access and fixed that as well. |
Member
|
Thanks a lot! Everything is working now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
make checkTesting
Fixes #104