Fixed Issue #32: Deadlock in Filter Chain When One Filter Fails #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cupsfilters/filter.c
Outdated
| } | ||
|
|
||
|
|
||
|
|
Member
There was a problem hiding this comment.
Please remove these added empty lines, they clutter the change.
cupsfilters/filter.c
Outdated
| if (log) log(ld, CF_LOGLEVEL_DEBUG, | ||
| "Closed the pipes for back and side channels"); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Please remove this added empty line.
Member
|
Now you have removed too many empty lines. Make sure that the sum of all your commits does not contain any whitespace-only changes, as addition or removal of blank lines, trailing spaces, or the newline in the end of the file. |
cupsfilters/filter.c
Outdated
| if (log) log(ld, CF_LOGLEVEL_DEBUG, | ||
| "Closed the pipes for back and side channels"); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Could you make this go away? The original file ends with a newline character after this last bracket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves Issue #32, which caused a deadlock in the filter chain when one of the filters failed.
Changes Made:
This fix ensures that the filter chain does not get stuck, improving reliability. Please review and let me know if any changes are needed. 🚀