Skip to content

Canonicalization#74

Merged
yhteoh merged 7 commits intomainfrom
canonicalization
Jun 27, 2025
Merged

Canonicalization#74
yhteoh merged 7 commits intomainfrom
canonicalization

Conversation

@yhteoh
Copy link
Copy Markdown
Collaborator

@yhteoh yhteoh commented Jun 26, 2025

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    Math canonicalization incomplete and not stored with math passes
    Atomic canonicalization incomplete

  • What is the new behavior (if this is a feature change)?

  • More robust MathExpr canonicalization
  • Stored with other math passes
  • Added variable substitution
  • Enhanced simplification
  • Implemented rule to resolve relative and absolute timing for AtomicCircuit
  • Implemented rule to resolve hierarchical protocol into a SequentialProtocol of ParallelProtocol
  • Implemented canonicalization of AtomicCircuit
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    Incorporates Math Canonicalization #73

@yhteoh yhteoh requested a review from benjimaclellan June 26, 2025 21:30
@yhteoh yhteoh marked this pull request as ready for review June 26, 2025 21:30
Copy link
Copy Markdown
Member

@benjimaclellan benjimaclellan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@yhteoh yhteoh merged commit f2731f7 into main Jun 27, 2025
15 checks passed
@yhteoh yhteoh deleted the canonicalization branch June 27, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants