Skip to content

fix(view): preserve tab spacing in notes#1092

Open
huangse199 wants to merge 1 commit into
OpenRailAssociation:mainfrom
huangse199:cherrycashpilot/issue-693-note-tab-characters
Open

fix(view): preserve tab spacing in notes#1092
huangse199 wants to merge 1 commit into
OpenRailAssociation:mainfrom
huangse199:cherrycashpilot/issue-693-note-tab-characters

Conversation

@huangse199

@huangse199 huangse199 commented Jun 1, 2026

Copy link
Copy Markdown

Summary

  • Preserve pasted tab characters in note text by converting them to non-breaking spaces before SVG rendering.
  • Add regression coverage for tab spacing in NotesView.convertText.

Fixes #693

Test plan

  • npx prettier --write src/app/view/editor-main-view/data-views/notes.view.ts src/app/view/editor-main-view/data-views/notes.view.spec.ts
  • npx eslint src/app/view/editor-main-view/data-views/notes.view.ts src/app/view/editor-main-view/data-views/notes.view.spec.ts
  • git diff --check
  • npm run build:standalone

Note: ng test --include src/app/view/editor-main-view/data-views/notes.view.spec.ts --watch=false --browsers=ChromeHeadless did not complete in this local environment and was stopped; build and targeted lint pass.

Convert tab characters to non-breaking spaces before rendering note text so pasted tab spacing does not produce malformed SVG output.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@huangse199 huangse199 requested a review from a team as a code owner June 1, 2026 10:32

@aiAdrian aiAdrian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiAdrian

Copy link
Copy Markdown
Contributor

Please fix the build issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Weird things happen when trying weird caracters in notes

2 participants