fix(dialog): avoid trainrun close handle overflow#1093
Conversation
Keep the trainrun dialog drag/close handle within its declared bounds so Firefox does not leave an overflow artifact when closing the dialog.
|
Please update the commit message : fix(dialog): avoid trainrun close handle overflow Keep the trainrun dialog drag/close handle within its declared bounds Lines are too long . |
louisgreiner
left a comment
louisgreiner
left a comment
There was a problem hiding this comment.
Enregistrement.de.l.ecran.2026-06-01.145942.mp4
This PR does not fix the bug: a (faded) white square still appears at closing.
Remove the detached drag/close handle as soon as the dialog starts closing so Firefox cannot fade out its white background as a separate square. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Thanks for checking and for the video. I pushed an additional fix: the drag/close handle is now removed as soon as the dialog starts closing, so Firefox should no longer fade out that detached white square during the close animation. I also kept the previous bounds fix in place. I could not run the full local lint here because this environment has Node v20.17.0 while the project dependencies require at least Node v20.19.0 / v22.12.0, and |
louisgreiner
left a comment
louisgreiner
left a comment
There was a problem hiding this comment.
That's indeed working. Nevertheless, it looks like a big hammer
| width: 20px; | ||
| height: 326px; | ||
| border: 16px solid var(--sbb-header-lean-background-color); | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
| box-sizing: border-box; |
This has then become useless
3 participants
Summary
Validation
Closes #739